Remove outdated TODO comments.
Rewrite some other TODO comments.
Remove references to tarpaulin.
(cargo-tarpaulin is a tool used for code coverage. Masonry hasn't used
it for years, and anyway we'll probably use `#[coverage]` annotations
once they stabilize.)
---------
Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
**Draft**
This PR is the proposal for xilem docs starting page. But I think I will
be able to make some more commits to improve documentation.
---------
Co-authored-by: Artyom Sinyugin <writers@altlinux.org>
Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
Co-authored-by: Tom Churchman <thomas@kepow.org>
Make tests more spread out and more readable.
Add comments detailing the state of the arena being tested.
Fix a lifetime error in unsafe API.
Rename Arena[Ref/Mut]Children to Arena[Ref/Mut]List
Rename a lot of methods.
Rework documentation.
Unify safe and unsafe APIs.
This PR includes improvements to page selector.
Specifically it now shows the full percentage range instead of just the
start of it, and it hides the buttons when you reach the end of the
range.
For some reason it panics when I get to the end.
Having `Box<dyn Widget>` implement the `Widget` trait is a crutch that
makes a bunch of things more complicated.
It leads to double-boxing in cases when the `dyn Widget` is itself a
`Box<dyn Widget>` (especially since the arena's current implementation
boxes all widgets by default), makes it harder to reason about
downcasting, and ends up producing a lot of code to handle the edge
cases.
On the xilem side, `Box<dyn Widget>` is slightly redundant with
`DynWidget`.
This PR still leaves a lot of boxing. On the long term, we'd like for
the arena to pack arbitrary widgets efficiently using some kind of
archetype scheme, but in the meantime, boxing will have to do.
Changes in this PR:
- New `FromDynWidget` trait that maybe-downcasts widgets to a
maybe-sized `Widget` type.
- Most places that accept `Widget` now accept `Widget + ?Sized`.
- Remove `impl Widget for Box<dyn Widget>`.
- Replace all instances of `WidgetPod<Box<dyn Widget>>` with
`WidgetPod<dyn Widget>`.
- Replace all instances of `xilem::Pod<Box<dyn Widget>>` with
`xilem::Pod<dyn Widget>`.
- Rename WidgetPod to WidgetBox in xilem_core example to avoid
ambiguity.
Rewrite "Creating a new Widget" tutorial to interleave description of
the Widget trait with example.
Go into more details.
Rewrite tutorials to use current WidgetMut syntax (the one with free
functions instead of methods).
Some notes:
1) The accessibility of this example probably isn't great. Not sure what
to do about this.
2) Our layout primitives aren't great; we use a grid, but ideally the
number of rows would be reactive to the available space.
3) The pagination is slightly hacked together - it should really try and
give you page numbers. I'm not planning to address this, unless someone
provides the algorithm
This was originally created to act as a screenshot for
https://github.com/linebender/linebender.github.io/pull/56
Previously, the use of `WidgetPod` made it impossible to create
"wrapper" widgets for certain properties. This new design "decomposes"
that `WidgetPod` for use in `Xilem`.
Open question: Is this new type more widely useful to other users of
Masonry? Xilem would need a wrapper
Open question: How will having multiple event handlers for a single
widget work? I imagine they would all use the same view path, and pass
on the event if it's not relevant.
Follow-up work:
- Splitting `Button` so that the handlers are wrappers
- Maybe: Splitting `TextArea` so that the handlers are wrappers (ooh, we
can probably properly support different binding models!)
- Removing the unnecessary and bloated `transform` field from each
Widget.
`libegl1-mesa` seems to have been an old name, which is no longer
accurate, and is not published for Ubuntu 24.
I don't know where this was publicised, but hopefully this change fixes
CI?
Clear the focus when user clicks outside of the focused widget
Add `most_recently_clicked_widget` value, so that clicking influences
which widget will be focused by future Tab events.
Move `#[allow(missing_docs)]` to two modules. Missing docs now warn
everywhere else by default.
Remove `#[expect(rustdoc::broken_intra_doc_links)]` and fix all broken
links.
Apply many small tweaks I found while going over the documentation.
Rename some variables.
Add asserts to `BoxConstraints::constrain_aspect_ratio`.
Flesh out the WidgetState documentation.
Introduce the concept of "zombie flags".
Adds a new `zstack` Xilem view (along with an accompanied Masonry
widget).
The view is inspired by the [ZStack view in
SwiftUI](https://developer.apple.com/documentation/swiftui/zstack),
which composes the child view on top of each other.
This pull-request is still work-in-progress.
- [x] It doesn't allow for changing the layout when BoxConstraints of
the children are different.
(top-left, top-right, bottom-left, bottom-right, center).
- [x] I want to update `http_cat` to put copyright on top of image like
seen below.
<img width="500" alt="Screenshot 2024-11-10 at 17 46 45"
src="https://github.com/user-attachments/assets/004d5779-142e-45a2-92d2-bdd5ddd9e2d1">
Olivier FAURE