Commit Graph

5894 Commits

Author SHA1 Message Date
JP Simard d369c09265
[CI] Generate docs with Buildkite instead of Azure Pipelines 2022-10-23 13:28:53 -04:00
JP Simard b4f45aa55e
Move TSan Runs CI job to Buildkite (#4457)
Now that we have more Buildkite machines, these should be faster than
running on Azure Pipelines.

Also remove the `//bazel:xcode_config` configurations since they should
no longer be in use.
2022-10-23 13:05:28 -04:00
JP Simard f0f46a45eb
[OSSCheck] Cache repos (#4456)
This should speed up OSSCheck runs considerably.

In my local testing, cloning repos goes from 77s to 29s on a 100 Mbps
connection.
2022-10-23 12:20:11 -04:00
JP Simard 1ee5154687
Update SwiftSyntax to `fa7ff05` (#4455)
There's a new SwiftParserDiagnostics module and the rewriter visit
function signatures changed.
2022-10-23 11:56:22 -04:00
JP Simard 401d0f7929
Update SwiftSyntax to `60c7037` (#4454)
This has changes to how comments are associated to nodes.

See https://github.com/apple/swift-syntax/pull/985
2022-10-23 11:15:27 -04:00
Marcelo Fabri 25a04e8eeb
Migrate `inclusive_language` rule to SwiftSyntax (#4390) 2022-10-23 14:00:40 +00:00
Marcelo Fabri 0bd9e4e65f
Rewrite `unused_optional_binding` with SwiftSyntax (#4449) 2022-10-23 06:13:54 -07:00
Marcelo Fabri 60054da0f7
Rewrite `prefer_self_type_over_type_of_self` with SwiftSyntax (#4451) 2022-10-23 06:06:16 -07:00
Marcelo Fabri 35fcf55198
Rewrite `reduce_into` rule with SwiftSyntax (#4447) 2022-10-23 07:58:48 -04:00
Marcelo Fabri cee4af098f
Migrate `prefer_zero_over_explicit_init` to SwiftSyntax (#4448) 2022-10-23 04:53:00 -07:00
Marcelo Fabri 9c8708bc01
Extract common SwiftSyntax extensions (#4445) 2022-10-23 00:54:18 -07:00
Marcelo Fabri 7b1099a33d
Rewrite `prefixed_toplevel_constant` with SwiftSyntax (#4425) 2022-10-21 13:11:40 -07:00
JP Simard 359699cea7
Report memory usage when `--benchmark` is specified (#4442)
With the memory increase related to
https://github.com/apple/swift-syntax/issues/921,
I wanted a way to quickly know how much memory was being used by
SwiftLint.

Here's how much memory it took to lint SwiftLint itself at various
versions in the last few weeks:

* 0.49.1: 223 MB
* 0.50.0-rc.1: 356 MB
* 0.50.0-rc.2: 444 MB
* main (458916174): 464 MB

```console
$ swiftlint --progress --benchmark
Linting Swift files in current working directory
529 of 529 [==============================] ETA: 0s (121 files/s)
Done linting! Found 0 violations, 0 serious in 529 files.
Memory used: 464 MB
$ swiftlint --progress --benchmark
Linting Swift files in current working directory
529 of 529 [==============================] ETA: 0s (16220 files/s)
Done linting! Found 0 violations, 0 serious in 529 files.
Memory used: 55.8 MB
```
2022-10-21 19:04:43 +00:00
JP Simard 4589161742
Rewrite `redundant_objc_attribute` with SwiftSyntax (#4441) 2022-10-21 18:28:21 +00:00
JP Simard 5af8e3dd68
Rewrite `lower_acl_than_parent` with SwiftSyntax (#4432)
And fix violations in SwiftLint.
2022-10-21 09:31:10 -04:00
Marcelo Fabri 1fb04902c0
Rewrite `multiline_parameters` rule with SwiftSyntax (#4438) 2022-10-21 09:08:27 +00:00
Marcelo Fabri 0dfc7a85b5
Rewrite `required_deinit` rule with SwiftSyntax (#4439) 2022-10-21 08:33:54 +00:00
Marcelo Fabri a4fbec355c
Validate protocols in `type_name` rule (#4433)
Fixes #4430
2022-10-21 00:11:18 -07:00
Marcelo Fabri 8f3a23e1a9
[oss-check] Add Pocket-Casts (#4436) 2022-10-20 19:04:43 -07:00
Marcelo Fabri ead4ca9b56
Revert "Add Automattic/pocket-casts-ios to oss-check (#4434)" (#4435)
This reverts commit 2d76e43068.
2022-10-20 18:54:10 -07:00
Marcelo Fabri 9f4b2c37ba
Rewrite `for_where`, adding `allow_for_as_filter` config (#4154) 2022-10-20 18:47:31 -07:00
Marcelo Fabri f509998ec1
Rewrite `empty_count` with SwiftSyntax (#4426) 2022-10-20 16:52:30 -07:00
Marcelo Fabri 2d76e43068
Add Automattic/pocket-casts-ios to oss-check (#4434) 2022-10-20 16:51:44 -07:00
JP Simard e84430f222
Update SwiftSyntax (#4431) 2022-10-20 13:16:00 -04:00
Marcelo Fabri 469a3aa87a
Rewrite `type_name` rule with SwiftSyntax (#4428) 2022-10-20 09:22:39 -07:00
Marcelo Fabri 59ad84f6e9
Add ns_number_init_as_function_reference rule (#4414) 2022-10-20 09:15:17 -07:00
Marcelo Fabri fd722892e5
Rewrite `notification_center_detachment` with SwiftSyntax (#4422) 2022-10-20 09:14:51 -07:00
Marcelo Fabri c46fd55711
Migrate `file_name` rule to SwiftSyntax (#4423) 2022-10-20 09:14:08 -07:00
Marcelo Fabri 2929e35183
Rewrite `single_test_class` rule with SwiftSyntax (#4424) 2022-10-20 09:13:23 -07:00
Marcelo Fabri 533917dced
Rewrite `raw_value_for_camel_cased_codable_enum` with SwiftSyntax (#4427) 2022-10-20 08:23:32 -07:00
JP Simard 25c9d34f5a
Update SwiftSyntax (#4429) 2022-10-20 09:21:14 -04:00
Marcelo Fabri d11dc2b321
Add changelog for https://github.com/realm/SwiftLint/pull/4421 2022-10-19 23:24:16 -07:00
Marcelo Fabri 62c8985a3e
Make `Quick*` rules more permissive (#4421)
Fixes #4420
2022-10-19 16:08:35 -07:00
JP Simard 230688848e
Update CI docs (#4419)
To reflect the need to install `bazelisk`.
2022-10-19 14:14:47 +00:00
JP Simard eb8971a933
Update CI docs (#4418)
Needs the `HOME` environment variable to bet set with some machines.
2022-10-19 09:10:36 -04:00
JP Simard 016831d471
Update CI machine setup instructions (#4416) 2022-10-19 07:49:18 -04:00
Marcelo Fabri 93b016bca3
Migrate `unavailable_function` to SwiftSyntax (#4387) 2022-10-18 20:19:27 -07:00
Marcelo Fabri bf716d7089
Rewrite `unused_capture_list` with SwiftSyntax (#4412) 2022-10-18 20:16:39 -07:00
Marcelo Fabri d3274565a1
Migrate `compiler_protocol_init` rule to SwiftSyntax (#4392) 2022-10-18 20:14:00 -07:00
Marcelo Fabri 04d7ce05ca
Rewrite `joined_default_parameter` with SwiftSyntax (#4411) 2022-10-18 20:12:56 -07:00
Marcelo Fabri bda8487ed2
Rewrite `prefer_nimble` rule with SwiftSyntax (#4410) 2022-10-18 01:42:08 -07:00
Danny Mösch a8bc9e9b42
Let more rules rely on SwiftSyntaxRule's defaults (#4401) 2022-10-18 02:23:39 -04:00
Marcelo Fabri 286e59a0e6
Fix false positive in `nsobject_prefer_isequal` rule (#4408)
Fixes #4404
2022-10-17 22:26:37 -07:00
Marcelo Fabri db910946dc
Simplift `DiscouragedNoneNameRule` implementation (#4407) 2022-10-18 04:43:40 +00:00
JP Simard 1837ae59cb
Rewrite `legacy_objc_type` with SwiftSyntax (#4372) 2022-10-17 17:29:09 -04:00
Marcelo Fabri 03848ce583
Make `DiscouragedNoneNameRule` opt-in again (#4403)
I mistakenly made it enable by default when rewriting it
2022-10-17 17:01:42 -04:00
JP Simard e9f2248072
Remove dead code in `DiscouragedDirectInitRule.swift` (#4402) 2022-10-17 18:25:02 +00:00
Marcelo Fabri 9a9629c1e8
Rewrite `discouraged_direct_init` with SwiftSyntax (#4397) 2022-10-17 10:47:46 -07:00
JP Simard 1b86aa7eeb
Simplify `SwitchCaseAlignmentRule` (#4399)
By using `ReasonedRuleViolation`, `SwiftSyntaxRule` and `makeVisitor()`.
2022-10-17 10:59:07 -04:00
JP Simard 8ec6e0eefc
Update SwiftSyntax (#4398)
https://github.com/apple/swift-syntax/pull/938 was impacting some
corrections in Lyft's codebase.
2022-10-17 09:42:02 -04:00