Remove redundancy code and improve validation logics in AgentChat (#6190)

Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
This commit is contained in:
湛露先生 2025-04-05 05:17:43 +08:00 committed by GitHub
parent 39321266f9
commit 27e1656e06
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 6 deletions

View File

@ -432,7 +432,6 @@ __all__ = [
"BaseChatMessage",
"BaseAgentEvent",
"BaseTextChatMessage",
"BaseChatMessage",
"StructuredContentType",
"StructuredMessage",
"HandoffMessage",

View File

@ -55,15 +55,17 @@ class BaseGroupChatManager(SequentialRoutedAgent, ABC):
GroupChatReset,
],
)
self._name = name
self._group_topic_type = group_topic_type
self._output_topic_type = output_topic_type
if max_turns is not None and max_turns <= 0:
raise ValueError("The maximum number of turns must be greater than 0.")
if len(participant_topic_types) != len(participant_descriptions):
raise ValueError("The number of participant topic types, agent types, and descriptions must be the same.")
if len(set(participant_topic_types)) != len(participant_topic_types):
raise ValueError("The participant topic types must be unique.")
if group_topic_type in participant_topic_types:
raise ValueError("The group topic type must not be in the participant topic types.")
self._name = name
self._group_topic_type = group_topic_type
self._output_topic_type = output_topic_type
self._participant_names = participant_names
self._participant_name_to_topic_type = {
name: topic_type for name, topic_type in zip(participant_names, participant_topic_types, strict=True)
@ -72,8 +74,6 @@ class BaseGroupChatManager(SequentialRoutedAgent, ABC):
self._message_thread: List[BaseAgentEvent | BaseChatMessage] = []
self._output_message_queue = output_message_queue
self._termination_condition = termination_condition
if max_turns is not None and max_turns <= 0:
raise ValueError("The maximum number of turns must be greater than 0.")
self._max_turns = max_turns
self._current_turn = 0
self._message_factory = message_factory