maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ELF] Handle GCC collect2 -plugin-opt= on Windows 

Follows up on commit cd5d5ce235 by
additionally ignoring relative paths ending in "lto-wrapper.exe" as
can be the case for GCC cross-compiled for Windows.

Reviewed By: tejohnson

Differential Revision: https://reviews.llvm.org/D138065
This commit is contained in:
Brett Werling 2022-11-16 08:16:11 -08:00 committed by Teresa Johnson
parent f678217c24
commit cf4f35b788
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lld/ELF/Driver.cpp
View File

@ -1360,12 +1360,15 @@ static void readConfigs(opt::InputArgList &args) {
parseClangOption(std::string("-") + arg->getValue(), arg->getSpelling());
// GCC collect2 passes -plugin-opt=path/to/lto-wrapper with an absolute or
// relative path. Just ignore. If not ended with "lto-wrapper", consider it an
// relative path. Just ignore. If not ended with "lto-wrapper" (or
// "lto-wrapper.exe" for GCC cross-compiled for Windows), consider it an
// unsupported LLVMgold.so option and error.
for (opt::Arg *arg : args.filtered(OPT_plugin_opt_eq))
if (!StringRef(arg->getValue()).endswith("lto-wrapper"))
for (opt::Arg *arg : args.filtered(OPT_plugin_opt_eq)) {
StringRef v(arg->getValue());
if (!v.endswith("lto-wrapper") && !v.endswith("lto-wrapper.exe"))
error(arg->getSpelling() + ": unknown plugin option '" + arg->getValue() +
"'");
}
config->passPlugins = args::getStrings(args, OPT_load_pass_plugins);

2
lld/test/ELF/lto-plugin-ignore.s
View File

@ -8,7 +8,9 @@
# RUN: ld.lld %t.o -o /dev/null \
# RUN: -plugin path/to/liblto_plugin.so \
# RUN: -plugin-opt=/path/to/lto-wrapper \
# RUN: -plugin-opt=/path/to/lto-wrapper.exe \
# RUN: -plugin-opt=relative/path/to/lto-wrapper \
# RUN: -plugin-opt=relative/path/to/lto-wrapper.exe \
# RUN: -plugin-opt=-fresolution=zed \
# RUN: -plugin-opt=-pass-through=-lgcc \
# RUN: -plugin-opt=-pass-through=-lgcc_eh \