maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[AArch64] Avoid emitting MOVID when NEON is disabled 

Previously, creating a zero floating-point constant used MOVID even when
NEON was disabled which resulted in the following fatal error:
`Attempting to emit MOVID instruction but the Feature_HasNEON predicate(s) are not met`

Reviewed By: dmgreen

Differential Revision: https://reviews.llvm.org/D125237
This commit is contained in:
Alex Richardson 2022-05-12 10:23:10 +00:00
parent 996873cdcb
commit c8b44600c5
2 changed files with 44 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp
View File

@ -1129,7 +1129,8 @@ void AArch64AsmPrinter::LowerFAULTING_OP(const MachineInstr &FaultingMI) {
void AArch64AsmPrinter::emitFMov0(const MachineInstr &MI) {
Register DestReg = MI.getOperand(0).getReg();
if (STI->hasZeroCycleZeroingFP() && !STI->hasZeroCycleZeroingFPWorkaround()) {
if (STI->hasZeroCycleZeroingFP() && !STI->hasZeroCycleZeroingFPWorkaround() &&
STI->hasNEON()) {
// Convert H/S register to corresponding D register
if (AArch64::H0 <= DestReg && DestReg <= AArch64::H31)
DestReg = AArch64::D0 + (DestReg - AArch64::H0);

42
llvm/test/CodeGen/AArch64/movid-no-neon.ll Normal file
View File

@ -0,0 +1,42 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc -mtriple=aarch64 -mattr=+fullfp16,+neon < %s | FileCheck %s --check-prefix=NEON-ENABLED
; RUN: llc -mtriple=aarch64 -mattr=+fullfp16,-neon < %s | FileCheck %s --check-prefix=NEON-DISABLED
define float @get_float() {
; NEON-ENABLED-LABEL: get_float:
; NEON-ENABLED: // %bb.0:
; NEON-ENABLED-NEXT: movi d0, #0000000000000000
; NEON-ENABLED-NEXT: ret
;
; NEON-DISABLED-LABEL: get_float:
; NEON-DISABLED: // %bb.0:
; NEON-DISABLED-NEXT: fmov s0, wzr
; NEON-DISABLED-NEXT: ret
ret float 0.000000e+00
}
define double @get_double() {
; NEON-ENABLED-LABEL: get_double:
; NEON-ENABLED: // %bb.0:
; NEON-ENABLED-NEXT: movi d0, #0000000000000000
; NEON-ENABLED-NEXT: ret
;
; NEON-DISABLED-LABEL: get_double:
; NEON-DISABLED: // %bb.0:
; NEON-DISABLED-NEXT: fmov d0, xzr
; NEON-DISABLED-NEXT: ret
ret double 0.000000e+00
}
define half @get_half() {
; NEON-ENABLED-LABEL: get_half:
; NEON-ENABLED: // %bb.0:
; NEON-ENABLED-NEXT: movi d0, #0000000000000000
; NEON-ENABLED-NEXT: ret
;
; NEON-DISABLED-LABEL: get_half:
; NEON-DISABLED: // %bb.0:
; NEON-DISABLED-NEXT: fmov h0, wzr
; NEON-DISABLED-NEXT: ret
ret half 0.000000e+00
}