kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(aria): disregard text area textContent (#34544)

This commit is contained in:
Pavel Feldman 2025-01-29 16:06:07 -08:00 committed by GitHub
parent 4b5b326478
commit eff5cd6dbb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/playwright-core/src/server/injected/ariaSnapshot.ts
View File

@ -57,7 +57,8 @@ export function generateAriaTree(rootElement: Element): AriaSnapshot {
if (node.nodeType === Node.TEXT_NODE && node.nodeValue) { if (node.nodeType === Node.TEXT_NODE && node.nodeValue) {
const text = node.nodeValue; const text = node.nodeValue;
if (text) // <textarea>AAA</textarea> should not report AAA as a child of the textarea.
if (ariaNode.role !== 'textbox' && text)
ariaNode.children.push(node.nodeValue || ''); ariaNode.children.push(node.nodeValue || '');
return; return;
} }

13
tests/page/page-aria-snapshot.spec.ts
View File

@ -605,3 +605,16 @@ it('should escape special yaml values', async ({ page }) => {
- textbox: "555" - textbox: "555"
`); `);
}); });
it('should not report textarea textContent', async ({ page }) => {
await page.setContent(`<textarea>Before</textarea>`);
await checkAndMatchSnapshot(page.locator('body'), `
- textbox: Before
`);
await page.evaluate(() => {
document.querySelector('textarea').value = 'After';
});
await checkAndMatchSnapshot(page.locator('body'), `
- textbox: After
`);
});