kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: remove setAutoCloseAllowed (#34273)

This commit is contained in:
Yury Semikhatsky 2025-01-09 14:16:01 -08:00 committed by GitHub
parent 201fc48cf0
commit cd9d02faf9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
packages/playwright-core/src/server/debugController.ts
View File

@ -40,9 +40,6 @@ export class DebugController extends SdkObject {
SetModeRequested: 'setModeRequested', SetModeRequested: 'setModeRequested',
}; };
private _autoCloseTimer: NodeJS.Timeout | undefined;
// TODO: remove in 1.27
private _autoCloseAllowed = false;
private _trackHierarchyListener: InstrumentationListener | undefined; private _trackHierarchyListener: InstrumentationListener | undefined;
private _playwright: Playwright; private _playwright: Playwright;
_sdkLanguage: Language = 'javascript'; _sdkLanguage: Language = 'javascript';
@ -58,13 +55,8 @@ export class DebugController extends SdkObject {
this._sdkLanguage = sdkLanguage; this._sdkLanguage = sdkLanguage;
} }
setAutoCloseAllowed(allowed: boolean) {
this._autoCloseAllowed = allowed;
}
dispose() { dispose() {
this.setReportStateChanged(false); this.setReportStateChanged(false);
this.setAutoCloseAllowed(false);
} }
setReportStateChanged(enabled: boolean) { setReportStateChanged(enabled: boolean) {
@ -102,7 +94,6 @@ export class DebugController extends SdkObject {
recorder.hideHighlightedSelector(); recorder.hideHighlightedSelector();
recorder.setMode('none'); recorder.setMode('none');
} }
this.setAutoCloseEnabled(true);
return; return;
} }
@ -127,23 +118,6 @@ export class DebugController extends SdkObject {
recorder.setOutput(this._codegenId, params.file); recorder.setOutput(this._codegenId, params.file);
recorder.setMode(params.mode); recorder.setMode(params.mode);
} }
this.setAutoCloseEnabled(true);
}
async setAutoCloseEnabled(enabled: boolean) {
if (!this._autoCloseAllowed)
return;
if (this._autoCloseTimer)
clearTimeout(this._autoCloseTimer);
if (!enabled)
return;
const heartBeat = () => {
if (!this._playwright.allPages().length)
gracefullyProcessExitDoNotHang(0);
else
this._autoCloseTimer = setTimeout(heartBeat, 5000);
};
this._autoCloseTimer = setTimeout(heartBeat, 30000);
} }
async highlight(params: { selector?: string, ariaTemplate?: string }) { async highlight(params: { selector?: string, ariaTemplate?: string }) {