kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore(bidi): hardcode "default" id for persistent context (#35303)

This commit is contained in:
Yury Semikhatsky 2025-03-20 13:42:48 -07:00 committed by GitHub
parent fbffb8152f
commit b9ccc5b252
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/playwright-core/src/server/bidi/bidiBrowser.ts
View File

@ -98,13 +98,9 @@ export class BidiBrowser extends Browser {
}); });
if (options.persistent) { if (options.persistent) {
const { userContexts } = await browser._browserSession.send('browser.getUserContexts', {});
if (!userContexts.length)
throw new Error('Cannot dermine default context id, no contexts found.');
const context = new BidiBrowserContext(browser, undefined, options.persistent); const context = new BidiBrowserContext(browser, undefined, options.persistent);
context._defaultUserContext = userContexts[0].userContext;
browser._defaultContext = context; browser._defaultContext = context;
await (browser._defaultContext as BidiBrowserContext)._initialize(); await context._initialize();
// Create default page as we cannot get access to the existing one. // Create default page as we cannot get access to the existing one.
const page = await browser._defaultContext.doCreateNewPage(); const page = await browser._defaultContext.doCreateNewPage();
await page.waitForInitializedOrError(); await page.waitForInitializedOrError();
@ -209,7 +205,6 @@ export class BidiBrowser extends Browser {
export class BidiBrowserContext extends BrowserContext { export class BidiBrowserContext extends BrowserContext {
declare readonly _browser: BidiBrowser; declare readonly _browser: BidiBrowser;
private _initScriptIds: bidi.Script.PreloadScript[] = []; private _initScriptIds: bidi.Script.PreloadScript[] = [];
_defaultUserContext: bidi.Browser.UserContext | undefined;
constructor(browser: BidiBrowser, browserContextId: string | undefined, options: types.BrowserContextOptions) { constructor(browser: BidiBrowser, browserContextId: string | undefined, options: types.BrowserContextOptions) {
super(browser, options, browserContextId); super(browser, options, browserContextId);
@ -376,7 +371,9 @@ export class BidiBrowserContext extends BrowserContext {
private _userContextId(): bidi.Browser.UserContext { private _userContextId(): bidi.Browser.UserContext {
if (this._browserContextId) if (this._browserContextId)
return this._browserContextId; return this._browserContextId;
return this._defaultUserContext!; // Default context always has same id, see
// https://w3c.github.io/webdriver-bidi/#default-user-context
return 'default';
} }
} }