kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: call findChromiumChannel only for Chromium based browsers (#35580)

This commit is contained in:
Yury Semikhatsky 2025-04-10 10:26:36 -07:00 committed by GitHub
parent 6c3e507dcb
commit b10f920a15
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/playwright-core/src/server/launchApp.ts
View File

@ -36,6 +36,7 @@ export async function launchApp(browserType: BrowserType, options: {
}) { }) {
const args = [...options.persistentContextOptions?.args ?? []]; const args = [...options.persistentContextOptions?.args ?? []];
let channel = options.persistentContextOptions?.channel;
if (browserType.name() === 'chromium') { if (browserType.name() === 'chromium') {
args.push( args.push(
'--app=data:text/html,', '--app=data:text/html,',
@ -43,12 +44,14 @@ export async function launchApp(browserType: BrowserType, options: {
...(options.windowPosition ? [`--window-position=${options.windowPosition.x},${options.windowPosition.y}`] : []), ...(options.windowPosition ? [`--window-position=${options.windowPosition.x},${options.windowPosition.y}`] : []),
'--test-type=', '--test-type=',
); );
if (!channel && !options.persistentContextOptions?.executablePath)
channel = findChromiumChannel(options.sdkLanguage);
} }
const context = await browserType.launchPersistentContext(serverSideCallMetadata(), '', { const context = await browserType.launchPersistentContext(serverSideCallMetadata(), '', {
ignoreDefaultArgs: ['--enable-automation'], ignoreDefaultArgs: ['--enable-automation'],
...options?.persistentContextOptions, ...options?.persistentContextOptions,
channel: options.persistentContextOptions?.channel ?? (!options.persistentContextOptions?.executablePath ? findChromiumChannel(options.sdkLanguage) : undefined), channel,
noDefaultViewport: options.persistentContextOptions?.noDefaultViewport ?? true, noDefaultViewport: options.persistentContextOptions?.noDefaultViewport ?? true,
acceptDownloads: options?.persistentContextOptions?.acceptDownloads ?? (isUnderTest() ? 'accept' : 'internal-browser-default'), acceptDownloads: options?.persistentContextOptions?.acceptDownloads ?? (isUnderTest() ? 'accept' : 'internal-browser-default'),
colorScheme: options?.persistentContextOptions?.colorScheme ?? 'no-override', colorScheme: options?.persistentContextOptions?.colorScheme ?? 'no-override',