From afa0bf224748d77f5dc03b8d84c9bb7ed109a2fe Mon Sep 17 00:00:00 2001 From: Joe-Hendley <95080839+Joe-Hendley@users.noreply.github.com> Date: Fri, 31 May 2024 18:45:56 +0100 Subject: [PATCH] feat: increase length of printed html tags (#31105) resolves https://github.com/microsoft/playwright/issues/30977 by increasing the printed length of HTML tags from 50 -> 500 as suggested by @dgozman --- packages/playwright-core/src/server/injected/injectedScript.ts | 2 +- tests/library/hit-target.spec.ts | 2 +- tests/page/elementhandle-convenience.spec.ts | 2 +- tests/page/page-wait-for-selector-1.spec.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/playwright-core/src/server/injected/injectedScript.ts b/packages/playwright-core/src/server/injected/injectedScript.ts index c988143a8f..dba8d188e4 100644 --- a/packages/playwright-core/src/server/injected/injectedScript.ts +++ b/packages/playwright-core/src/server/injected/injectedScript.ts @@ -983,7 +983,7 @@ export class InjectedScript { attrs.push(` ${name}="${value}"`); } attrs.sort((a, b) => a.length - b.length); - const attrText = trimStringWithEllipsis(attrs.join(''), 50); + const attrText = trimStringWithEllipsis(attrs.join(''), 500); if (autoClosingTags.has(element.nodeName)) return oneLine(`<${element.nodeName.toLowerCase()}${attrText}/>`); diff --git a/tests/library/hit-target.spec.ts b/tests/library/hit-target.spec.ts index 0b3d0f6597..6bf4085b6b 100644 --- a/tests/library/hit-target.spec.ts +++ b/tests/library/hit-target.spec.ts @@ -253,7 +253,7 @@ it('should not click iframe overlaying the target', async ({ page, server }) => `); const error = await page.click('text=click-me', { timeout: 1000 }).catch(e => e); expect(await page.evaluate('window._clicked')).toBe(undefined); - expect(error.message).toContain(` from
…
subtree intercepts pointer events`); }); it('should not click an element overlaying iframe with the target', async ({ page, server }) => { diff --git a/tests/page/elementhandle-convenience.spec.ts b/tests/page/elementhandle-convenience.spec.ts index 5020f34ea8..8e2f4895bf 100644 --- a/tests/page/elementhandle-convenience.spec.ts +++ b/tests/page/elementhandle-convenience.spec.ts @@ -34,7 +34,7 @@ it('should have a nice preview for non-ascii attributes/children', async ({ page await page.goto(server.EMPTY_PAGE); await page.setContent(`
${'πŸ˜›'.repeat(100)}`); const handle = await page.$('div'); - await expect.poll(() => String(handle)).toBe(`JSHandle@
πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›β€¦
`); + await expect.poll(() => String(handle)).toBe(`JSHandle@
πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›πŸ˜›β€¦
`); }); it('getAttribute should work', async ({ page, server }) => { diff --git a/tests/page/page-wait-for-selector-1.spec.ts b/tests/page/page-wait-for-selector-1.spec.ts index d20165af66..3ab3e92b73 100644 --- a/tests/page/page-wait-for-selector-1.spec.ts +++ b/tests/page/page-wait-for-selector-1.spec.ts @@ -135,7 +135,7 @@ it('should report logs while waiting for visible', async ({ page, server }) => { const error = await watchdog.catch(e => e); expect(error.message).toContain(`frame.waitForSelector: Timeout 5000ms exceeded.`); expect(error.message).toContain(`waiting for locator(\'div\') to be visible`); - expect(error.message).toContain(`locator resolved to hidden
abcdefghijklmnopqrstuvwyxzabcdefghijklmnopqrstuvw…
`); expect(error.message).toContain(`locator resolved to hidden
`); });