kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(runner): hide `APIResponse.*` calls from results (#34909)

This commit is contained in:
Simon Knott 2025-02-25 14:26:54 +01:00 committed by GitHub
parent 81855d11e4
commit 9e38473309
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
packages/playwright-core/src/client/fetch.ts
View File

@ -338,16 +338,18 @@ export class APIResponse implements api.APIResponse {
}
async body(): Promise<Buffer> {
try {
const result = await this._request._channel.fetchResponseBody({ fetchUid: this._fetchUid() });
if (result.binary === undefined)
throw new Error('Response has been disposed');
return result.binary;
} catch (e) {
if (isTargetClosedError(e))
throw new Error('Response has been disposed');
throw e;
}
return await this._request._wrapApiCall(async () => {
try {
const result = await this._request._channel.fetchResponseBody({ fetchUid: this._fetchUid() });
if (result.binary === undefined)
throw new Error('Response has been disposed');
return result.binary;
} catch (e) {
if (isTargetClosedError(e))
throw new Error('Response has been disposed');
throw e;
}
}, true);
}
async text(): Promise<string> {

2
tests/playwright-test/test-step.spec.ts
View File

@ -1520,9 +1520,7 @@ pw:api | browserContext.newPage
test.step |custom step @ a.test.ts:4
pw:api | page.route @ a.test.ts:5
pw:api | page.goto(${server.EMPTY_PAGE}) @ a.test.ts:12
pw:api | apiResponse.text @ a.test.ts:7
expect | expect.toBe @ a.test.ts:8
pw:api | apiResponse.text @ a.test.ts:9
hook |After Hooks
fixture | fixture: page
fixture | fixture: context