kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add more installation test scenarios (#27240)

This commit is contained in:
Dmitry Gozman 2023-10-02 21:10:26 -07:00 committed by GitHub
parent 567386c23f
commit 9116a81c17
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 36 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/installation/globalSetup.ts
View File

@ -54,6 +54,8 @@ async function globalSetup() {
build('playwright-browser-chromium', '@playwright/browser-chromium'),
build('playwright-browser-firefox', '@playwright/browser-firefox'),
build('playwright-browser-webkit', '@playwright/browser-webkit'),
build('playwright-ct-react', '@playwright/experimental-ct-react'),
build('playwright-ct-core', '@playwright/experimental-ct-core'),
]);
const buildPlaywrightTestPlugin = async () => {
@ -67,7 +69,7 @@ async function globalSetup() {
const tgzName = packResult.stdout.trim();
const outPath = path.resolve(path.join(outputDir, `playwright-test-plugin.tgz`));
await fs.promises.rename(path.join(cwd, tgzName), outPath);
console.log('Built playwright-test-plugin');
console.log('Built: playwright-test-plugin');
return ['playwright-test-plugin', outPath];
};
builds.push(await buildPlaywrightTestPlugin());

32
tests/installation/npmTest.ts
View File

@ -153,24 +153,25 @@ export const test = _test
args = argsAndOrOptions as string[];
let result!: {stdout: string, stderr: string, code: number | null, error?: Error};
const cwd = options.cwd ?? tmpWorkspace;
// NB: We end up running npm-in-npm, so it's important that we do NOT forward process.env and instead cherry-pick environment variables.
const PATH = sanitizeEnvPath(process.env.PATH || '');
const env = {
'PATH': PATH,
'DISPLAY': process.env.DISPLAY,
'XAUTHORITY': process.env.XAUTHORITY,
...(isolateBrowsers ? { PLAYWRIGHT_BROWSERS_PATH: _browsersPath } : {}),
...options.env,
};
await test.step(`exec: ${[cmd, ...args].join(' ')}`, async () => {
result = await spawnAsync(cmd, args, {
shell: true,
cwd: options.cwd ?? tmpWorkspace,
// NB: We end up running npm-in-npm, so it's important that we do NOT forward process.env and instead cherry-pick environment variables.
env: {
'PATH': process.env.PATH,
'DISPLAY': process.env.DISPLAY,
'XAUTHORITY': process.env.XAUTHORITY,
...(isolateBrowsers ? { PLAYWRIGHT_BROWSERS_PATH: _browsersPath } : {}),
...options.env,
}
});
result = await spawnAsync(cmd, args, { shell: true, cwd, env });
});
const command = [cmd, ...args].join(' ');
const stdio = result.stdout + result.stderr;
await testInfo.attach(command, { body: `COMMAND: ${command}\n\nEXIT CODE: ${result.code}\n\n====== STDOUT + STDERR ======\n\n${stdio}` });
const commandEnv = Object.entries(env).map(e => `${e[0]}=${e[1]}`).join(' ');
const fullCommand = `cd ${cwd} && ${commandEnv} ${command}`;
await testInfo.attach(command, { body: `COMMAND: ${fullCommand}\n\nEXIT CODE: ${result.code}\n\n====== STDOUT + STDERR ======\n\n${stdio}` });
// This means something is really off with spawn
if (result.error)
@ -200,5 +201,10 @@ export const test = _test
},
});
function sanitizeEnvPath(value: string) {
if (process.platform === 'win32')
return value.split(';').filter(path => !path.endsWith('node_modules\\.bin')).join(';');
return value.split(':').filter(path => !path.endsWith('node_modules/.bin')).join(':');
}
export { expect };

15
tests/installation/playwright-test-package-managers.spec.ts
View File

@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { test } from './npmTest';
import { test, expect } from './npmTest';
import path from 'path';
test('npm: @playwright/test should work', async ({ exec, tmpWorkspace }) => {
@ -45,6 +45,19 @@ test('npm: @playwright/test + playwright-core should work', async ({ exec, tmpWo
await exec('node', 'esm-playwright-test.mjs');
});
test('npm: @playwright/test should install playwright-core bin', async ({ exec, tmpWorkspace }) => {
await exec('npm i @playwright/test');
const result = await exec('npx playwright-core --version');
expect(result).toContain('Version 1.');
});
test('npm: uninstalling ct removes playwright bin', async ({ exec, tmpWorkspace }) => {
await exec('npm i @playwright/test');
await exec('npm i @playwright/experimental-ct-react');
await exec('npm uninstall @playwright/experimental-ct-react');
await exec('npx playwright test', { expectToExitWithError: true, message: 'command not found' });
});
test('yarn: @playwright/test should work', async ({ exec, tmpWorkspace }) => {
await exec('yarn add @playwright/test');
await exec('yarn playwright install');