kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cherry-pick(#28197): fix(chromium): properly detect session closed errors for oopifs (#28508) 

This PR cherry-picks the following commits:

- da6707f785

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This commit is contained in:
Playwright Service 2023-12-06 13:53:00 -08:00 committed by GitHub
parent 268942037a
commit 8aef8e8fc2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/playwright-core/src/server/chromium/crPage.ts
View File

@ -46,6 +46,7 @@ import type { Protocol } from './protocol';
import { VideoRecorder } from './videoRecorder'; import { VideoRecorder } from './videoRecorder';
import { BrowserContext } from '../browserContext'; import { BrowserContext } from '../browserContext';
import { TargetClosedError } from '../errors'; import { TargetClosedError } from '../errors';
import { isSessionClosedError } from '../protocolError';
const UTILITY_WORLD_NAME = '__playwright_utility_world__'; const UTILITY_WORLD_NAME = '__playwright_utility_world__';
@ -132,7 +133,7 @@ export class CRPage implements PageDelegate {
return cb(frameSession); return cb(frameSession);
return cb(frameSession).catch(e => { return cb(frameSession).catch(e => {
// Broadcasting a message to the closed iframe should be a noop. // Broadcasting a message to the closed iframe should be a noop.
if (e.message && e.message.includes('Target closed')) if (isSessionClosedError(e))
return; return;
throw e; throw e;
}); });