kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(trace-viewer): ConsoleTab: each child in a list should have a unique "key" prop (#35413)

This commit is contained in:
Max Schmitt 2025-03-31 08:30:53 +01:00 committed by GitHub
parent 81c6af0cc6
commit 63cf78471f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/trace-viewer/src/ui/consoleTab.tsx
View File

@ -200,38 +200,38 @@ function format(args: { preview: string, value: any }[]): JSX.Element[] {
let match;
const formatted: JSX.Element[] = [];
let tokens: JSX.Element[] = [];
formatted.push(<span>{tokens}</span>);
formatted.push(<span key={formatted.length + 1}>{tokens}</span>);
let formatIndex = 0;
while ((match = regex.exec(messageFormat)) !== null) {
const text = messageFormat.substring(formatIndex, match.index);
tokens.push(<span>{text}</span>);
tokens.push(<span key={tokens.length + 1}>{text}</span>);
formatIndex = match.index + 2;
const specifier = match[0][1];
if (specifier === '%') {
tokens.push(<span>%</span>);
tokens.push(<span key={tokens.length + 1}>%</span>);
} else if (specifier === 's' || specifier === 'o' || specifier === 'O' || specifier === 'd' || specifier === 'i' || specifier === 'f') {
const value = tail[argIndex++];
const styleObject: any = {};
if (typeof value?.value !== 'string')
styleObject['color'] = 'var(--vscode-debugTokenExpression-number)';
tokens.push(<span style={styleObject}>{value?.preview || ''}</span>);
tokens.push(<span key={tokens.length + 1} style={styleObject}>{value?.preview || ''}</span>);
} else if (specifier === 'c') {
tokens = [];
const format = tail[argIndex++];
const styleObject = format ? parseCSSStyle(format.preview) : {};
formatted.push(<span style={styleObject}>{tokens}</span>);
formatted.push(<span key={formatted.length + 1} style={styleObject}>{tokens}</span>);
}
}
if (formatIndex < messageFormat.length)
tokens.push(<span>{messageFormat.substring(formatIndex)}</span>);
tokens.push(<span key={tokens.length + 1}>{messageFormat.substring(formatIndex)}</span>);
for (; argIndex < tail.length; argIndex++) {
const value = tail[argIndex];
const styleObject: any = {};
if (tokens.length)
tokens.push(<span> </span>);
tokens.push(<span key={tokens.length + 1}> </span>);
if (typeof value?.value !== 'string')
styleObject['color'] = 'var(--vscode-debugTokenExpression-number)';
tokens.push(<span style={styleObject}>{value?.preview || ''}</span>);
tokens.push(<span key={tokens.length + 1} style={styleObject}>{value?.preview || ''}</span>);
}
return formatted;
}