kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: allow disposing ElementHandles multiple times (#29953) 

Fixes https://github.com/microsoft/playwright/issues/29945
This commit is contained in:
Max Schmitt 2024-03-15 16:26:56 +01:00 committed by GitHub
parent 3e78426acc
commit 5bc6ca6345
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/playwright-core/src/client/jsHandle.ts
View File

@ -19,6 +19,7 @@ import { ChannelOwner } from './channelOwner';
import { parseSerializedValue, serializeValue } from '../protocol/serializers'; import { parseSerializedValue, serializeValue } from '../protocol/serializers';
import type * as api from '../../types/types'; import type * as api from '../../types/types';
import type * as structs from '../../types/structs'; import type * as structs from '../../types/structs';
import { isTargetClosedError } from './errors';
export class JSHandle<T = any> extends ChannelOwner<channels.JSHandleChannel> implements api.JSHandle { export class JSHandle<T = any> extends ChannelOwner<channels.JSHandleChannel> implements api.JSHandle {
private _preview: string; private _preview: string;
@ -68,7 +69,13 @@ export class JSHandle<T = any> extends ChannelOwner<channels.JSHandleChannel> im
} }
async dispose() { async dispose() {
return await this._channel.dispose(); try {
await this._channel.dispose();
} catch (e) {
if (isTargetClosedError(e))
return;
throw e;
}
} }
async _objectCount() { async _objectCount() {

9
tests/page/elementhandle-misc.spec.ts
View File

@ -85,3 +85,12 @@ it('should focus a button', async ({ page, server }) => {
await button.focus(); await button.focus();
expect(await button.evaluate(button => document.activeElement === button)).toBe(true); expect(await button.evaluate(button => document.activeElement === button)).toBe(true);
}); });
it('should allow disposing twice', async ({ page }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/29945' });
await page.setContent('<section>39</section>');
const element = await page.$('section');
expect(element).toBeTruthy();
await element.dispose();
await element.dispose();
});