kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(recorder): allow clearing when recording is disabled (#33821)

This commit is contained in:
Simon Knott 2024-12-06 10:17:06 -08:00 committed by GitHub
parent a56a5cabbd
commit 4914f34a83
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/playwright-core/src/server/recorder/recorderCollection.ts
View File

@ -38,7 +38,7 @@ export class RecorderCollection extends EventEmitter {
restart() {
this._actions = [];
this._fireChange();
this.emit('change', []);
}
setEnabled(enabled: boolean) {
@ -128,6 +128,7 @@ export class RecorderCollection extends EventEmitter {
private _fireChange() {
if (!this._enabled)
return;
this.emit('change', collapseActions(this._actions));
}
}

30
tests/library/inspector/cli-codegen-1.spec.ts
View File

@ -926,4 +926,34 @@ await page.GetByRole(AriaRole.Button, new() { Name = "Submit" }).ClickAsync();`)
const predicate = (msg: ConsoleMessage) => msg.type() === 'error' && /Content[\- ]Security[\- ]Policy/i.test(msg.text());
await expect(page.waitForEvent('console', { predicate, timeout: 1000 })).rejects.toThrow();
});
test('should clear when recording is disabled', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/33802' } }, async ({ openRecorder }) => {
const { recorder } = await openRecorder();
await recorder.setContentAndWait(`
<button id="foo" onclick="console.log('click')">Foo</button>
<button id="bar" onclick="console.log('click')">Bar</button>
`);
await recorder.hoverOverElement('#foo');
let [sources] = await Promise.all([
recorder.waitForOutput('JavaScript', 'click'),
recorder.trustedClick(),
]);
expect(sources.get('JavaScript').text).toContain(`getByRole('button', { name: 'Foo' }).click()`);
await recorder.recorderPage.getByRole('button', { name: 'Record' }).click();
await recorder.recorderPage.getByRole('button', { name: 'Clear' }).click();
await recorder.recorderPage.getByRole('button', { name: 'Record' }).click();
await recorder.hoverOverElement('#bar');
[sources] = await Promise.all([
recorder.waitForOutput('JavaScript', 'click'),
recorder.trustedClick(),
]);
expect(sources.get('JavaScript').text).toContain(`getByRole('button', { name: 'Bar' }).click()`);
expect(sources.get('JavaScript').text).not.toContain(`getByRole('button', { name: 'Foo' })`);
});
});