chore: send aria snapshot to the debug controller (#33969)
This commit is contained in:
parent
0e2b984287
commit
29fd2df124
|
@ -385,6 +385,7 @@ scheme.DebugControllerInitializer = tOptional(tObject({}));
|
|||
scheme.DebugControllerInspectRequestedEvent = tObject({
|
||||
selector: tString,
|
||||
locator: tString,
|
||||
ariaSnapshot: tString,
|
||||
});
|
||||
scheme.DebugControllerSetModeRequestedEvent = tObject({
|
||||
mode: tString,
|
||||
|
|
|
@ -228,7 +228,7 @@ class InspectingRecorderApp extends EmptyRecorderApp {
|
|||
|
||||
override async elementPicked(elementInfo: ElementInfo): Promise<void> {
|
||||
const locator: string = asLocator(this._debugController._sdkLanguage, elementInfo.selector);
|
||||
this._debugController.emit(DebugController.Events.InspectRequested, { selector: elementInfo.selector, locator });
|
||||
this._debugController.emit(DebugController.Events.InspectRequested, { selector: elementInfo.selector, locator, ariaSnapshot: elementInfo.ariaSnapshot });
|
||||
}
|
||||
|
||||
override async setSources(sources: Source[]): Promise<void> {
|
||||
|
|
|
@ -32,8 +32,8 @@ export class DebugControllerDispatcher extends Dispatcher<DebugController, chann
|
|||
eventsHelper.addEventListener(this._object, DebugController.Events.StateChanged, params => {
|
||||
this._dispatchEvent('stateChanged', params);
|
||||
}),
|
||||
eventsHelper.addEventListener(this._object, DebugController.Events.InspectRequested, ({ selector, locator }) => {
|
||||
this._dispatchEvent('inspectRequested', { selector, locator });
|
||||
eventsHelper.addEventListener(this._object, DebugController.Events.InspectRequested, ({ selector, locator, ariaSnapshot }) => {
|
||||
this._dispatchEvent('inspectRequested', { selector, locator, ariaSnapshot });
|
||||
}),
|
||||
eventsHelper.addEventListener(this._object, DebugController.Events.SourceChanged, ({ text, header, footer, actions }) => {
|
||||
this._dispatchEvent('sourceChanged', ({ text, header, footer, actions }));
|
||||
|
|
|
@ -691,6 +691,7 @@ export interface DebugControllerChannel extends DebugControllerEventTarget, Chan
|
|||
export type DebugControllerInspectRequestedEvent = {
|
||||
selector: string,
|
||||
locator: string,
|
||||
ariaSnapshot: string,
|
||||
};
|
||||
export type DebugControllerSetModeRequestedEvent = {
|
||||
mode: string,
|
||||
|
|
|
@ -807,6 +807,7 @@ DebugController:
|
|||
parameters:
|
||||
selector: string
|
||||
locator: string
|
||||
ariaSnapshot: string
|
||||
|
||||
setModeRequested:
|
||||
parameters:
|
||||
|
|
|
@ -84,9 +84,11 @@ test('should pick element', async ({ backend, connectedBrowser }) => {
|
|||
|
||||
expect(events).toEqual([
|
||||
{
|
||||
ariaSnapshot: '- button "Submit"',
|
||||
selector: 'internal:role=button[name=\"Submit\"i]',
|
||||
locator: 'getByRole(\'button\', { name: \'Submit\' })',
|
||||
}, {
|
||||
ariaSnapshot: '- button "Submit"',
|
||||
selector: 'internal:role=button[name=\"Submit\"i]',
|
||||
locator: 'getByRole(\'button\', { name: \'Submit\' })',
|
||||
},
|
||||
|
|
Loading…
Reference in New Issue