kyfx
/
playwright
mirror of https://github.com/microsoft/playwright.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(reporter): remove stale annotations from JsonTestEnd (#35426)

This commit is contained in:
Adam Gastineau 2025-04-01 05:28:30 -07:00 committed by GitHub
parent 49c13a0788
commit 16f634649f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/playwright/src/isomorphic/teleReceiver.ts
View File

@ -75,7 +75,8 @@ export type JsonTestEnd = {
testId: string;
expectedStatus: reporterTypes.TestStatus;
timeout: number;
annotations: Annotation[];
// Dropped in 1.52. Kept as empty array for backwards compatibility.
annotations: [];
};
export type JsonTestResultStart = {
@ -235,7 +236,9 @@ export class TeleReporterReceiver {
const test = this._tests.get(testEndPayload.testId)!;
test.timeout = testEndPayload.timeout;
test.expectedStatus = testEndPayload.expectedStatus;
test.annotations = testEndPayload.annotations;
// Should be empty array, but if it's not, it represents all annotations for that test
if (testEndPayload.annotations.length > 0)
test.annotations = testEndPayload.annotations;
const result = test.results.find(r => r._id === payload.id)!;
result.duration = payload.duration;
result.status = payload.status;

2
packages/playwright/src/reporters/teleEmitter.ts
View File

@ -73,8 +73,8 @@ export class TeleReporterEmitter implements ReporterV2 {
const testEnd: teleReceiver.JsonTestEnd = {
testId: test.id,
expectedStatus: test.expectedStatus,
annotations: test.annotations,
timeout: test.timeout,
annotations: []
};
this._messageSink({
method: 'onTestEnd',