dnrops
/
xilem
mirror of https://github.com/linebender/xilem
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

masonry: `TextEditor` add `Action::TextChanged` for backspace & delete (#483) 

`masonry::text::edit::TextEditor` should emit an
`Action::TextChanged(...)` also on `Backspace` and `Delete` if anything
was deleted, so that e.g. `xilem::view::textbox::Textbox` receives this
action. This is already implemented for `Ctrl+Backspace` and
`Ctrl+Delete`.

The code changes are not elegant, but intended to be minimally invasive.

Local `cargo test` failed for the modified and an unmodified code, but
sometimes with different errors—which I do not quite understand.

I apologize in advance for any mistakes on my part, I've never before
worked on open source repos and did not find any guideline for your
project.
This commit is contained in:
edgy-sphere 2024-08-05 10:25:36 +02:00 committed by GitHub
parent 101fa9bb7d
commit 0bca54ae52
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
masonry/src/text/edit.rs
View File

@ -124,6 +124,9 @@ impl<T: EditableText> TextEditor<T> {
self.text_mut().edit(selection.range(), "");
self.inner.selection =
Some(Selection::caret(selection.min(), Affinity::Upstream));
let contents = self.text().as_str().to_string();
ctx.submit_action(Action::TextChanged(contents));
} else {
// TODO: more specific behavior may sometimes be warranted here
// because whole EGCs are more coarse than what people expect
@ -135,6 +138,9 @@ impl<T: EditableText> TextEditor<T> {
self.text_mut().edit(offset..selection.active, "");
self.inner.selection =
Some(Selection::caret(offset, selection.active_affinity));
let contents = self.text().as_str().to_string();
ctx.submit_action(Action::TextChanged(contents));
}
Handled::Yes
} else {
@ -149,6 +155,9 @@ impl<T: EditableText> TextEditor<T> {
selection.min(),
Affinity::Downstream,
));
let contents = self.text().as_str().to_string();
ctx.submit_action(Action::TextChanged(contents));
} else if let Some(offset) =
self.text().next_grapheme_offset(selection.active)
{
@ -157,6 +166,9 @@ impl<T: EditableText> TextEditor<T> {
selection.min(),
selection.active_affinity,
));
let contents = self.text().as_str().to_string();
ctx.submit_action(Action::TextChanged(contents));
}
Handled::Yes
} else {