dnrops
/
swift-nio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove useless instance variables in the SelectableEventLoop (#2338) 

Motivation:

Less code we have - less bugs we have.
The fix remove few lines of code keeping the same functionality.

Modifications:

Just remove some useless instance variables.

Result:

Less code.
This commit is contained in:
thomas-gill-0xff 2022-12-21 14:41:44 +03:00 committed by GitHub
parent 7e3b50b38e
commit b201ff561d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Sources/NIOPosix/SelectableEventLoop.swift
View File

@ -102,15 +102,10 @@ internal final class SelectableEventLoop: EventLoop {
private var internalState: InternalState = .runningAndAcceptingNewRegistrations // protected by the EventLoop thread private var internalState: InternalState = .runningAndAcceptingNewRegistrations // protected by the EventLoop thread
private var externalState: ExternalState = .open // protected by externalStateLock private var externalState: ExternalState = .open // protected by externalStateLock
private let _iovecs: UnsafeMutablePointer<IOVector>
private let _storageRefs: UnsafeMutablePointer<Unmanaged<AnyObject>>
let iovecs: UnsafeMutableBufferPointer<IOVector> let iovecs: UnsafeMutableBufferPointer<IOVector>
let storageRefs: UnsafeMutableBufferPointer<Unmanaged<AnyObject>> let storageRefs: UnsafeMutableBufferPointer<Unmanaged<AnyObject>>
// Used for gathering UDP writes. // Used for gathering UDP writes.
private let _msgs: UnsafeMutablePointer<MMsgHdr>
private let _addresses: UnsafeMutablePointer<sockaddr_storage>
let msgs: UnsafeMutableBufferPointer<MMsgHdr> let msgs: UnsafeMutableBufferPointer<MMsgHdr>
let addresses: UnsafeMutableBufferPointer<sockaddr_storage> let addresses: UnsafeMutableBufferPointer<sockaddr_storage>
@ -192,14 +187,10 @@ Further information:
self._parentGroup = parentGroup self._parentGroup = parentGroup
self._selector = selector self._selector = selector
self.thread = thread self.thread = thread
self._iovecs = UnsafeMutablePointer.allocate(capacity: Socket.writevLimitIOVectors) self.iovecs = UnsafeMutableBufferPointer<IOVector>.allocate(capacity: Socket.writevLimitIOVectors)
self._storageRefs = UnsafeMutablePointer.allocate(capacity: Socket.writevLimitIOVectors) self.storageRefs = UnsafeMutableBufferPointer<Unmanaged<AnyObject>>.allocate(capacity: Socket.writevLimitIOVectors)
self.iovecs = UnsafeMutableBufferPointer(start: self._iovecs, count: Socket.writevLimitIOVectors) self.msgs = UnsafeMutableBufferPointer<MMsgHdr>.allocate(capacity: Socket.writevLimitIOVectors)
self.storageRefs = UnsafeMutableBufferPointer(start: self._storageRefs, count: Socket.writevLimitIOVectors) self.addresses = UnsafeMutableBufferPointer<sockaddr_storage>.allocate(capacity: Socket.writevLimitIOVectors)
self._msgs = UnsafeMutablePointer.allocate(capacity: Socket.writevLimitIOVectors)
self._addresses = UnsafeMutablePointer.allocate(capacity: Socket.writevLimitIOVectors)
self.msgs = UnsafeMutableBufferPointer(start: _msgs, count: Socket.writevLimitIOVectors)
self.addresses = UnsafeMutableBufferPointer(start: _addresses, count: Socket.writevLimitIOVectors)
self.controlMessageStorage = UnsafeControlMessageStorage.allocate(msghdrCount: Socket.writevLimitIOVectors) self.controlMessageStorage = UnsafeControlMessageStorage.allocate(msghdrCount: Socket.writevLimitIOVectors)
// We will process 4096 tasks per while loop. // We will process 4096 tasks per while loop.
self.tasksCopy.reserveCapacity(4096) self.tasksCopy.reserveCapacity(4096)
@ -217,10 +208,10 @@ Further information:
"illegal internal state on deinit: \(self.internalState)") "illegal internal state on deinit: \(self.internalState)")
assert(self.externalState == .resourcesReclaimed, assert(self.externalState == .resourcesReclaimed,
"illegal external state on shutdown: \(self.externalState)") "illegal external state on shutdown: \(self.externalState)")
_iovecs.deallocate() self.iovecs.deallocate()
_storageRefs.deallocate() self.storageRefs.deallocate()
_msgs.deallocate() self.msgs.deallocate()
_addresses.deallocate() self.addresses.deallocate()
self.controlMessageStorage.deallocate() self.controlMessageStorage.deallocate()
} }