Merge pull request #5 from f-meloni/fix_execute_step

Fix executeStep method
This commit is contained in:
Franco Meloni 2018-12-07 16:44:16 +00:00 committed by GitHub
commit 2d534697b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 12 additions and 12 deletions

View File

@ -1,7 +1,7 @@
import Logger
final class CommitExecutor: ScriptLauncherExecutor<CommitParameters> {
func executeStep(version: String, logger: Logger) {
override func executeStep(version: String, logger: Logger) {
let message = parameters.message ?? "Version \(version)"
var scriptString = "git commit -m \"\(message)\""

View File

@ -6,4 +6,8 @@ class DefaultExecutor<T: StepParameters>: StepExecutor {
required init(dictionary: [String: Any]?) {
parameters = T(dictionary: dictionary)
}
func executeStep(version _: String, logger _: Logger) {
fatalError("Not implemented")
}
}

View File

@ -1,7 +1,7 @@
import Logger
final class GitAddExecutor: ScriptLauncherExecutor<GitAddParameters> {
func executeStep(version _: String, logger: Logger) {
override func executeStep(version _: String, logger: Logger) {
launchScript(content: "git add " + parameters.paths.joined(separator: " "), errorMessage: "Git Add step failed with error", logger: logger)
}
}

View File

@ -3,7 +3,7 @@ import Logger
final class HideDevDependenciesExecutor: DefaultExecutor<ModifyDevDependenciesParameters> {
var devDependenciesModifier: DevDependenciesModifing = DevDependenciesModifier()
func executeStep(version _: String, logger: Logger) {
override func executeStep(version _: String, logger: Logger) {
do {
try devDependenciesModifier.hideDependencies(packagePath: parameters.packagePath)
} catch {

View File

@ -1,7 +1,7 @@
import Logger
final class PushExecutor: ScriptLauncherExecutor<PushParameters> {
func executeStep(version _: String, logger: Logger) {
override func executeStep(version _: String, logger: Logger) {
var scriptString = "git push \(parameters.remote) \(parameters.branch) --tags"
if parameters.noVerify {

View File

@ -2,7 +2,7 @@ import Foundation
import Logger
final class ScriptExecutor: ScriptLauncherExecutor<ScriptParameters> {
func executeStep(version _: String, logger: Logger) {
override func executeStep(version _: String, logger: Logger) {
guard let content = parameters.content,
!content.isEmpty else {
logger.logError("Invalid script content")

View File

@ -6,7 +6,3 @@ public protocol StepExecutor {
init(dictionary: [String: Any]?)
}
extension StepExecutor {
func executeStep(version _: String, logger _: Logger) {}
}

View File

@ -5,7 +5,7 @@ final class SwiftScriptExecutor: DefaultExecutor<SwiftScriptParameters> {
lazy var fileManager: FileManager = .default
lazy var processLauncher: ProcessLaunching = ProcessLauncher()
func executeStep(version: String, logger: Logger) {
override func executeStep(version: String, logger: Logger) {
guard let scriptPath = parameters.scriptPath else {
logger.logError("Invalid script path for the Swift script step")
return

View File

@ -2,7 +2,7 @@ import Foundation
import Logger
final class TagExecutor: ScriptLauncherExecutor<TagParameters> {
func executeStep(version: String, logger: Logger) {
override func executeStep(version: String, logger: Logger) {
launchScript(content: "git tag \(version)", errorMessage: "Tag step failed with error", logger: logger)
}
}

View File

@ -3,7 +3,7 @@ import Logger
final class UnhideDevDependenciesExecutor: DefaultExecutor<ModifyDevDependenciesParameters> {
var devDependenciesModifier: DevDependenciesModifing = DevDependenciesModifier()
func executeStep(version _: String, logger: Logger) {
override func executeStep(version _: String, logger: Logger) {
do {
try devDependenciesModifier.unhideDependencies(packagePath: parameters.packagePath)
} catch {