dnrops
/
python-oracledb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed bugs in the implementation of the statement cache.

This commit is contained in:
Anthony Tuininga 2023-06-15 15:06:42 -06:00
parent 5ec3f5cc30
commit e0f06dbd47
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
doc/src/release_notes.rst
View File

@ -15,6 +15,7 @@ Thin Mode Changes
#) Fixed bug connecting to databases with older 11g password verifiers
(`issue 189 <https://github.com/oracle/python-oracledb/issues/189>`__).
#) Fixed bugs in the implementation of the statement cache.
Thick Mode Changes
++++++++++++++++++

11
src/oracledb/impl/thin/connection.pyx
View File

@ -237,11 +237,12 @@ cdef class ThinConnImpl(BaseConnImpl):
if statement is None:
statement = Statement()
statement._prepare(sql)
if len(self._statement_cache) < self._statement_cache_size \
and cache_statement \
and not self._drcp_establish_session:
self._statement_cache[sql] = statement
if cache_statement and not self._drcp_establish_session \
and not statement._is_ddl \
and self._statement_cache_size > 0:
statement._return_to_cache = True
self._statement_cache[sql] = statement
self._adjust_statement_cache()
elif statement._in_use or not cache_statement \
or self._drcp_establish_session:
if not cache_statement:
@ -283,8 +284,6 @@ cdef class ThinConnImpl(BaseConnImpl):
with self._statement_cache_lock:
if statement._return_to_cache:
statement._in_use = False
self._statement_cache.move_to_end(statement._sql)
self._adjust_statement_cache()
elif statement._cursor_id != 0:
self._add_cursor_to_close(statement)