Cursor.callproc method changed with respect to doc (#287)

Signed-off-by: Andrey Petukhov <APetukhov@bellintegrator.com>

src/cxoCursor.c

@@ -1327,7 +1327,11 @@ static PyObject *cxoCursor_callProc(cxoCursor *cursor, PyObject *args,
         return NULL;
 
     // create the return value
-    numArgs = PyList_GET_SIZE(cursor->bindVariables);
+    numArgs = 0;
+    if (listOfArguments) {
+        //check already made in cxoCursor_call
+        numArgs = PySequence_Size(listOfArguments);
+    }
     results = PyList_New(numArgs);
     if (!results)
         return NULL;

test/Cursor.py

@@ -86,6 +86,37 @@ class TestCase(TestEnv.BaseTestCase):
         results = self.cursor.callproc("proc_Test", ("hi", 5, var))
         self.assertEqual(results, ["hi", 10, 2.0])
 
+    def testCallProcAllKeywords(self):
+        """test executing a stored procedure with arguments in keywordParameters"""
+        kwargs = dict(
+            a_InValue = "hi",
+            a_InOutValue = self.cursor.var(cx_Oracle.NUMBER),
+            a_OutValue = self.cursor.var(cx_Oracle.NUMBER),
+        )
+        kwargs['a_InOutValue'].setvalue(0, 5)
+        results = self.cursor.callproc("proc_Test", keywordParameters=kwargs)
+        self.assertEqual(results, [])
+        self.assertEqual(kwargs['a_InOutValue'].getvalue(), 10)
+        self.assertEqual(kwargs['a_OutValue'].getvalue(), 2.0)
+
+    def testCallProcOnlyLastKeyword(self):
+        """test executing a stored procedure with last argument in keywordParameters"""
+        kwargs = dict(
+            a_OutValue = self.cursor.var(cx_Oracle.NUMBER),
+        )
+        results = self.cursor.callproc("proc_Test", ("hi",5), kwargs)
+        self.assertEqual(results, ["hi", 10])
+        self.assertEqual(kwargs['a_OutValue'].getvalue(), 2.0)
+
+    def testCallProcRepeatedKeywordParameters(self):
+        """test executing a stored procedure with repeated argument in keywordParameters"""
+        kwargs = dict(
+            a_InValue = "hi",
+            a_OutValue = self.cursor.var(cx_Oracle.NUMBER),
+        )
+        self.assertRaises(cx_Oracle.DatabaseError, self.cursor.callproc,
+                "proc_Test", parameters=("hi",5), keywordParameters=kwargs)
+
     def testCallProcNoArgs(self):
         """test executing a stored procedure without any arguments"""
         results = self.cursor.callproc(u"proc_TestNoArgs")