dnrops
/
mise
mirror of https://github.com/jdx/mise
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(ubi): URL syntax fails (#4859) 

As discussed in #4856
This commit is contained in:
Roland Schaer 2025-04-16 13:33:03 -03:00 committed by GitHub
parent f47c0f4a89
commit 8aa1417ae1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 29 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
e2e/backend/test_ubi
View File

@ -5,6 +5,12 @@ assert "mise x ubi:goreleaser/goreleaser@v1.25.0 -- goreleaser -v | grep -o 1.25
mise use ubi:kellyjonbrazil/jc@1.25.3
assert_contains "$MISE_DATA_DIR/shims/jc --version" "jc version: 1.25.3"
# only run on linux/amd64
if [ "$(uname -m)" = "x86_64" ] && [ "$(uname -s)" = "Linux" ]; then
mise use ubi:https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-master-latest-linux64-gpl.tar.xz[exe=ffmpeg]
assert_contains "$MISE_DATA_DIR/shims/ffmpeg -version" "ffmpeg version"
fi
cat <<EOF >mise.toml
[tools]
"ubi:cilium/cilium-cli" = { version = "latest", exe = "cilium" }

9
src/backend/ubi.rs
View File

@ -120,6 +120,7 @@ impl Backend for UbiBackend {
let extract_all = opts.get("extract_all").is_some_and(|v| v == "true");
let bin_dir = tv.install_path();
if !name_is_url(&self.tool_name()) {
let release: Result<_, eyre::Report> = match forge {
ForgeType::GitHub => {
github::get_release_for_url(api_url, &self.tool_name(), &v).map(|_| "github")
@ -138,14 +139,18 @@ impl Backend for UbiBackend {
v = format!("v{v}");
// }
}
}
let install = |v: &str| {
// Workaround because of not knowing how to pull out the value correctly without quoting
let name = self.tool_name();
let mut builder = UbiBuilder::new().project(&name).install_dir(&bin_dir);
let mut builder = UbiBuilder::new().install_dir(&bin_dir);
if v != "latest" {
if name_is_url(&name) {
builder = builder.url(&name);
} else {
builder = builder.project(&name);
builder = builder.tag(v);
}