dnrops
/
gsoc-swift-baggage-context
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

!logging #30 logger need not be { set }

This commit is contained in:
Konrad `ktoso` Malawski 2020-08-28 11:35:37 +09:00
parent 5f4ae4a898
commit bc38a06a92
2 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Sources/BaggageLogging/LoggingBaggageContextCarrier.swift
View File

@ -29,5 +29,5 @@ public protocol LoggingBaggageContextCarrier: BaggageContextCarrier {
///
/// Writes to the `logger` metadata SHOULD NOT be reflected in the `baggage`,
/// however writes to the underlying `baggage` SHOULD be reflected in the `logger`.
var logger: Logger { get set }
var logger: Logger { get }
}

14
Tests/BaggageLoggingTests/LoggingBaggageContextCarrierTests.swift
View File

@ -71,12 +71,7 @@ public struct ExampleFrameworkContext: LoggingBaggageContextCarrier {
private var _logger: Logger
public var logger: Logger {
get {
return self._logger.with(context: self.baggage)
}
set {
self._logger = newValue
}
return self._logger.with(context: self.baggage)
}
public init(context baggage: BaggageContext, logger: Logger) {
@ -88,12 +83,7 @@ public struct ExampleFrameworkContext: LoggingBaggageContextCarrier {
struct CoolFrameworkContext: LoggingBaggageContextCarrier {
private var _logger: Logger = Logger(label: "some frameworks logger")
var logger: Logger {
get {
return self._logger.with(context: self.baggage)
}
set {
self._logger = newValue
}
return self._logger.with(context: self.baggage)
}
var baggage: BaggageContext = .init()