dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #13367: show commit in about dialog in all non-release builds. 

The commit hash is not that useful on releases, even for unstable
releases, because a release is always at a known tagged commit anyway.

Note that I only change this for the About dialog where it's less
visible, and not on the canvas, because I do appreciate that stable
series show with a clean empty canvas. I like stable series to be closer
to a release state (even though it's true that having the commit hash
accessible somewhere for dev/continuous build is a useful feature).

Sorry to translators too! I break the string freeze during the stable
series. It's a string only visible on dev builds anyway, so it's not a
very urgent string anyway. Thanks for all the hard translation work! 🤗
This commit is contained in:
Jehan 2025-04-03 18:18:06 +02:00 committed by Bruno
parent 9d6f80c9dc
commit c893a96298
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/dialogs/about-dialog.c
View File

@ -95,10 +95,10 @@ static gboolean about_dialog_anim_draw (GtkWidget *widget,
static void about_dialog_reshuffle (GimpAboutDialog *dialog); static void about_dialog_reshuffle (GimpAboutDialog *dialog);
static gboolean about_dialog_timer (gpointer data); static gboolean about_dialog_timer (gpointer data);
#ifdef GIMP_UNSTABLE #ifndef GIMP_RELEASE
static void about_dialog_add_unstable_message static void about_dialog_add_unstable_message
(GtkWidget *vbox); (GtkWidget *vbox);
#endif /* GIMP_UNSTABLE */ #endif /* ! GIMP_RELEASE */
static void about_dialog_last_release_changed static void about_dialog_last_release_changed
(GimpCoreConfig *config, (GimpCoreConfig *config,
@ -202,9 +202,9 @@ about_dialog_create (Gimp *gimp,
{ {
if (dialog.use_animation) if (dialog.use_animation)
about_dialog_add_animation (children->data, &dialog); about_dialog_add_animation (children->data, &dialog);
#ifdef GIMP_UNSTABLE #ifndef GIMP_RELEASE
about_dialog_add_unstable_message (children->data); about_dialog_add_unstable_message (children->data);
#endif /* GIMP_UNSTABLE */ #endif /* ! GIMP_RELEASE */
#ifdef CHECK_UPDATE #ifdef CHECK_UPDATE
if (gimp_version_check_update ()) if (gimp_version_check_update ())
about_dialog_add_update (&dialog, config); about_dialog_add_update (&dialog, config);
@ -794,7 +794,7 @@ about_dialog_timer (gpointer data)
return G_SOURCE_CONTINUE; return G_SOURCE_CONTINUE;
} }
#ifdef GIMP_UNSTABLE #ifndef GIMP_RELEASE
static void static void
about_dialog_add_unstable_message (GtkWidget *vbox) about_dialog_add_unstable_message (GtkWidget *vbox)
@ -802,7 +802,7 @@ about_dialog_add_unstable_message (GtkWidget *vbox)
GtkWidget *label; GtkWidget *label;
gchar *text; gchar *text;
text = g_strdup_printf (_("This is an unstable development release\n" text = g_strdup_printf (_("This is a development build\n"
"commit %s"), GIMP_GIT_VERSION_ABBREV); "commit %s"), GIMP_GIT_VERSION_ABBREV);
label = gtk_label_new (text); label = gtk_label_new (text);
g_free (text); g_free (text);
@ -817,7 +817,7 @@ about_dialog_add_unstable_message (GtkWidget *vbox)
gtk_widget_show (label); gtk_widget_show (label);
} }
#endif /* GIMP_UNSTABLE */ #endif /* ! GIMP_RELEASE */
static void static void
about_dialog_last_release_changed (GimpCoreConfig *config, about_dialog_last_release_changed (GimpCoreConfig *config,