dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Win32] Plug handle leak, call CloseHandle(). 

2003-07-30  Tor Lillqvist  <tml@iki.fi>

	* app/plug-in/plug-in.c (plug_in_close): [Win32] Plug handle leak,
	call CloseHandle().
This commit is contained in:
Tor Lillqvist 2003-07-31 01:08:08 +00:00 committed by Tor Lillqvist
parent 117d73cea3
commit ac5dfb4774
3 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2003-07-30 Tor Lillqvist <tml@iki.fi>
* app/plug-in/plug-in.c (plug_in_close): [Win32] Plug handle leak,
call CloseHandle().
2003-07-30 Manish Singh <yosh@gimp.org> 2003-07-30 Manish Singh <yosh@gimp.org>
* tools/pdbgen/app.pl: fixed UTF-8 reversed check. * tools/pdbgen/app.pl: fixed UTF-8 reversed check.

8
app/plug-in/gimpplugin.c
View File

@ -508,8 +508,8 @@ plug_in_close (PlugIn *plug_in,
gboolean kill_it) gboolean kill_it)
{ {
Gimp *gimp; Gimp *gimp;
gint status;
#ifndef G_OS_WIN32 #ifndef G_OS_WIN32
gint status;
struct timeval tv; struct timeval tv;
#endif #endif
@ -570,6 +570,12 @@ plug_in_close (PlugIn *plug_in,
TerminateProcess ((HANDLE) plug_in->pid, 0); TerminateProcess ((HANDLE) plug_in->pid, 0);
} }
} }
/* FIXME: Wait for it like on Unix? */
/* Close handle which is no longer needed */
if (plug_in->pid)
CloseHandle ((HANDLE) plug_in->pid);
#endif #endif
plug_in->pid = 0; plug_in->pid = 0;

8
app/plug-in/plug-in.c
View File

@ -508,8 +508,8 @@ plug_in_close (PlugIn *plug_in,
gboolean kill_it) gboolean kill_it)
{ {
Gimp *gimp; Gimp *gimp;
gint status;
#ifndef G_OS_WIN32 #ifndef G_OS_WIN32
gint status;
struct timeval tv; struct timeval tv;
#endif #endif
@ -570,6 +570,12 @@ plug_in_close (PlugIn *plug_in,
TerminateProcess ((HANDLE) plug_in->pid, 0); TerminateProcess ((HANDLE) plug_in->pid, 0);
} }
} }
/* FIXME: Wait for it like on Unix? */
/* Close handle which is no longer needed */
if (plug_in->pid)
CloseHandle ((HANDLE) plug_in->pid);
#endif #endif
plug_in->pid = 0; plug_in->pid = 0;