dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

app: fix propgui random seed generation 

After the switch of random-seed properties from INT to UINT, their
upper bound results in a negative value when converted to a
gint32, causing a CRITICAL in the call to g_random_int_range().
Use g_random_double_range() instead, which has enough precision to
accurately represent all values in the range, and round the result.
This commit is contained in:
Ell 2018-05-04 13:34:21 -04:00
parent 48f6d1b8ee
commit 07c81abf01
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/propgui/gimppropgui-utils.c
View File

@ -23,6 +23,7 @@
#include <gegl.h> #include <gegl.h>
#include <gtk/gtk.h> #include <gtk/gtk.h>
#include "libgimpmath/gimpmath.h"
#include "libgimpwidgets/gimpwidgets.h" #include "libgimpwidgets/gimpwidgets.h"
#include "propgui-types.h" #include "propgui-types.h"
@ -211,8 +212,10 @@ static void
gimp_prop_random_seed_new_clicked (GtkButton *button, gimp_prop_random_seed_new_clicked (GtkButton *button,
GtkAdjustment *adj) GtkAdjustment *adj)
{ {
guint32 value = g_random_int_range (gtk_adjustment_get_lower (adj), guint32 value;
gtk_adjustment_get_upper (adj));
value = floor (g_random_double_range (gtk_adjustment_get_lower (adj),
gtk_adjustment_get_upper (adj) + 1.0));
gtk_adjustment_set_value (adj, value); gtk_adjustment_set_value (adj, value);
} }