dnrops
/
gimp
mirror of https://github.com/GNOME/gimp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #3133: Gimp freezes after selecting a filter preset and... 

... clicking a GimpChain.
Since commit c0c055b4e9, gimp_chain_button_set_active() emits the
"toggled" signal. There is no need to emit it separately from
GimpOperationTool when setting presets with
gimp_operation_tool_set_config().

In particular, since the "toggled" signal was even sent unconditionnally
here, our code was ending creating several GBinding for the same 2
adjustments, which was creating an infinite loop.
This commit is contained in:
Jehan 2019-03-20 14:48:40 +01:00
parent af6760b3c9
commit 03dc24455a
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/tools/gimpoperationtool.c
View File

@ -755,8 +755,6 @@ gimp_operation_tool_unlink_chains (GimpOperationTool *op_tool)
if (active)
{
gimp_chain_button_set_active (chain, FALSE);
g_signal_emit_by_name (chain, "toggled");
}
chains = chains->next;
@ -800,8 +798,6 @@ gimp_operation_tool_relink_chains (GimpOperationTool *op_tool)
g_value_get_double (&double_y))
{
gimp_chain_button_set_active (chain, TRUE);
g_signal_emit_by_name (chain, "toggled");
}
g_value_unset (&double_x);