dnrops
/
dotnet_runtime
mirror of https://github.com/dotnet/runtime
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update globalconfigs with recently added rules (#77538) 

* Update globalconfigs with recently added rules

* Fix Fill(0) to Clear() in NTAuthentication
This commit is contained in:
Stephen Toub 2022-10-28 17:19:53 -04:00 committed by GitHub
parent cc5ba0994d
commit c0d2dda671
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 39 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
eng/CodeAnalysis.src.globalconfig
View File

@ -214,6 +214,9 @@ dotnet_diagnostic.CA1420.severity = warning
# CA1421: This method uses runtime marshalling even when the 'DisableRuntimeMarshallingAttribute' is applied
dotnet_diagnostic.CA1421.severity = suggestion
# CA1422: Validate platform compatibility
dotnet_diagnostic.CA1422.severity = warning
# CA1501: Avoid excessive inheritance
dotnet_diagnostic.CA1501.severity = none
@ -414,6 +417,9 @@ dotnet_diagnostic.CA1853.severity = warning
# CA1854: Prefer the 'IDictionary.TryGetValue(TKey, out TValue)' method
dotnet_diagnostic.CA1854.severity = warning
# CA1855: Prefer 'Clear' over 'Fill'
dotnet_diagnostic.CA1855.severity = warning
# CA2000: Dispose objects before losing scope
dotnet_diagnostic.CA2000.severity = none
@ -595,6 +601,9 @@ dotnet_diagnostic.CA2258.severity = warning
# CA2259: 'ThreadStatic' only affects static fields
dotnet_diagnostic.CA2259.severity = warning
# CA2260: Use correct type parameter
dotnet_diagnostic.CA2260.severity = warning
# CA2300: Do not use insecure deserializer BinaryFormatter
dotnet_diagnostic.CA2300.severity = none
@ -1579,10 +1588,10 @@ dotnet_diagnostic.IDE0180.severity = suggestion
dotnet_diagnostic.IDE0200.severity = warning
# IDE0210: Use top-level statements
dotnet_diagnostic.IDE0210.severity = silent
dotnet_diagnostic.IDE0210.severity = none
# IDE0211: Use program main
dotnet_diagnostic.IDE0211.severity = silent
dotnet_diagnostic.IDE0211.severity = none
# IDE0220: foreach cast
dotnet_diagnostic.IDE0220.severity = silent
@ -1590,6 +1599,15 @@ dotnet_diagnostic.IDE0220.severity = silent
# IDE0230: Use UTF8 string literal
dotnet_diagnostic.IDE0230.severity = suggestion
# IDE0240: Remove redundant nullable directive
dotnet_diagnostic.IDE0240.severity = suggestion
# IDE0241: Remove unnecessary nullable directive
dotnet_diagnostic.IDE0241.severity = suggestion
# IDE0250: Make struct readonly
dotnet_diagnostic.IDE0250.severity = suggestion
# IDE1005: Delegate invocation can be simplified.
dotnet_diagnostic.IDE1005.severity = warning

18
eng/CodeAnalysis.test.globalconfig
View File

@ -213,6 +213,9 @@ dotnet_diagnostic.CA1420.severity = none
# CA1421: This method uses runtime marshalling even when the 'DisableRuntimeMarshallingAttribute' is applied
dotnet_diagnostic.CA1421.severity = none
# CA1422: Validate platform compatibility
dotnet_diagnostic.CA1422.severity = none
# CA1501: Avoid excessive inheritance
dotnet_diagnostic.CA1501.severity = none
@ -411,6 +414,9 @@ dotnet_diagnostic.CA1853.severity = none
# CA1854: Prefer the 'IDictionary.TryGetValue(TKey, out TValue)' method
dotnet_diagnostic.CA1854.severity = none
# CA1855: Prefer 'Clear' over 'Fill'
dotnet_diagnostic.CA1855.severity = none
# CA2000: Dispose objects before losing scope
dotnet_diagnostic.CA2000.severity = none
@ -591,6 +597,9 @@ dotnet_diagnostic.CA2258.severity = none
# CA2259: 'ThreadStatic' only affects static fields
dotnet_diagnostic.CA2259.severity = none
# CA2260: Use correct type parameter
dotnet_diagnostic.CA2260.severity = none
# CA2300: Do not use insecure deserializer BinaryFormatter
dotnet_diagnostic.CA2300.severity = none
@ -1584,6 +1593,15 @@ dotnet_diagnostic.IDE0220.severity = silent
# IDE0230: Use UTF8 string literal
dotnet_diagnostic.IDE0230.severity = silent
# IDE0240: Remove redundant nullable directive
dotnet_diagnostic.IDE0240.severity = silent
# IDE0241: Remove unnecessary nullable directive
dotnet_diagnostic.IDE0241.severity = silent
# IDE0250: Make struct readonly
dotnet_diagnostic.IDE0250.severity = silent
# IDE1005: Delegate invocation can be simplified.
dotnet_diagnostic.IDE1005.severity = silent

2
src/libraries/Common/src/System/Net/NTAuthentication.Managed.cs
View File

@ -712,7 +712,7 @@ namespace System.Net
// Create empty LM2 response.
SetField(ref response.LmChallengeResponse, ChallengeResponseLength, payloadOffset);
payload.Slice(payloadOffset, ChallengeResponseLength).Fill(0);
payload.Slice(payloadOffset, ChallengeResponseLength).Clear();
payloadOffset += ChallengeResponseLength;
// Create NTLM2 response