mirror of https://github.com/dotnet/runtime
Enable CA1863 (Use 'CompositeFormat') as suggestion (#89029)
I ran it over runtime, and the only things flagged were for exceptional cases where it's not worth using. Rather than a bunch of suppressions, I'm just enabling it as info-level.
This commit is contained in:
parent
c8d5367735
commit
023b54a2d4
|
@ -477,6 +477,9 @@ dotnet_diagnostic.CA1861.severity = warning
|
|||
# CA1862: Prefer using 'StringComparer'/'StringComparison' to perform case-insensitive string comparisons
|
||||
dotnet_diagnostic.CA1862.severity = warning
|
||||
|
||||
# CA1863: Use 'CompositeFormat'
|
||||
dotnet_diagnostic.CA1863.severity = suggestion
|
||||
|
||||
# CA1864: Prefer the 'IDictionary.TryAdd(TKey, TValue)' method
|
||||
dotnet_diagnostic.CA1864.severity = warning
|
||||
|
||||
|
|
|
@ -474,6 +474,9 @@ dotnet_diagnostic.CA1861.severity = none
|
|||
# CA1862: Prefer using 'StringComparer'/'StringComparison' to perform case-insensitive string comparisons
|
||||
dotnet_diagnostic.CA1862.severity = none
|
||||
|
||||
# CA1863: Use 'CompositeFormat'
|
||||
dotnet_diagnostic.CA1863.severity = none
|
||||
|
||||
# CA1864: Prefer the 'IDictionary.TryAdd(TKey, TValue)' method
|
||||
dotnet_diagnostic.CA1864.severity = none
|
||||
|
||||
|
|
|
@ -1895,8 +1895,8 @@ namespace System
|
|||
else if (!declaredType.IsAssignableFrom(reflectedType))
|
||||
{
|
||||
// declaredType is not Array, not generic, and not assignable from reflectedType
|
||||
throw new ArgumentException(string.Format(
|
||||
CultureInfo.CurrentCulture, SR.Argument_ResolveMethodHandle,
|
||||
throw new ArgumentException(SR.Format(
|
||||
SR.Argument_ResolveMethodHandle,
|
||||
reflectedType.ToString(), declaredType.ToString()));
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue