dnrops
/
clang
mirror of https://github.com/microsoft/clang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
73,147 Commits 3 Branches 0 Tags 180 MiB
Commit Graph

135 Commits

Author SHA1 Message Date
Jordy Rose ee2fde1293 [analyzer] Fix trivial errors in previous commit. 
I will not commit without building first.
I will not commit without building first.
I will not commit without building first...

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@133150 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-16 05:56:50 +00:00
Jordy Rose 1e022415b9 [analyzer] Cleanup: mainly 80-char violations and preferring SValBuilder::getComparisonType() to just referencing IntTy. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@133149 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-16 05:51:02 +00:00
Jordy Rose d5af0e17b0 [analyzer] Revise CStringChecker's modelling of strcpy() and strcat(): 
- (bounded copies) Be more conservative about how much is being copied.
- (str(n)cat) If we can't compute the exact final length of an append operation, we can still lower-bound it.
- (stpcpy) Fix the conjured return value at the end to actually be returned.

This requires these supporting changes:
- C string metadata symbols are still live even when buried in a SymExpr.
- "Hypothetical" C string lengths, to represent a value that /will/ be passed to setCStringLength() if all goes well. (The idea is to allow for temporary constrainable symbols that may end up becoming permanent.)
- The 'checkAdditionOverflow' helper makes sure that the two strings being appended in a strcat don't overflow size_t. This should never *actually* happen; the real effect is to keep the final string length from "wrapping around" in the constraint manager.

This doesn't actually test the "bounded" operations (strncpy and strncat) because they can leave strings unterminated. Next on the list!


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@133046 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-15 05:52:56 +00:00
Jordy Rose 210c05b103 [analyzer] If a C string length is UnknownVal, clear any existing length binding. No tests yet because the only thing that sets string length is strcpy(), and that needs some work anyway. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@133044 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-15 05:14:03 +00:00
Jordy Rose bd32beee8a [analyzer] Change large if body to early return. No functionality change. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@132956 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-14 01:26:48 +00:00
Jordy Rose 793bff3fb7 [analyzer] Fix modeling of strnlen to be more conservative. Move tests we can't properly model (yet?) to string-fail.c. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@132955 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-14 01:15:31 +00:00
Jordy Rose 7182b9652f [analyzer] Change an indent-if to an early return. No functionality change. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@132618 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-04 01:50:25 +00:00
Jordy Rose 3f8bb2fa28 [analyzer] Don't crash when copying an unknown number of bytes with memcpy(). Also handle all memcpy-family return values in evalCopyCommon(), rather than having some outside and some inside. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@132617 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-04 01:47:27 +00:00
Jordy Rose 7eb83caea1 [analyzer] Remove extra assignment that actually lost a few of the assumptions. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@132614 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-04 01:22:21 +00:00
Jordy Rose c152586baf [analyzer] Fix comment for (still-disabled) evalStrncpy 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@132608 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-04 00:05:23 +00:00
Jordy Rose 22d27178bf [analyzer] Fix handling of "copy zero bytes" for memcpy and friends. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@132607 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-04 00:04:22 +00:00
Jordy Rose be460d8e53 [analyzer] __mempcpy_chk is the same as mempcpy (at least to CStringChecker) 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@132605 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-06-03 23:42:56 +00:00
Lenny Maiorani 094ea0afcf Removing strncpy() checking in CString checker for now. Some significant changes need to be made to properly support modeling of it since it potentially leaves strings non-null terminated. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130758 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-05-03 16:34:26 +00:00
Ted Kremenek 35bdbf4062 Augment retain/release checker to not warn about tracked objects passed as arguments to C++ constructors. This is a stop-gap measure for Objective-C++ code that uses smart pointers to manage reference counts. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130711 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-05-02 19:42:42 +00:00
Lenny Maiorani 454fd2d3a1 Implements strncasecmp() checker and simplifies some of the logic around creating substrings if necessary and calling the appropriate StringRef::compare/compare_lower(). 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130708 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-05-02 19:05:49 +00:00
Lenny Maiorani 401549d71f Use StringRef::substr() and unbounded StringRef::compare() instead of bounded version of StringRef::compare() because bounded version of StringRef::compare() is going to be removed. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130425 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-04-28 19:31:12 +00:00
Lenny Maiorani 508c627db6 Eliminates an assert in the strncpy/strncat checker caused by not validating a cast was successful. If the value of an argument was unknown, the cast would result in a NULL pointer which was later being dereferenced. 
This fixes Bugzilla #9806.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130422 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-04-28 18:59:43 +00:00
Lenny Maiorani bd1d16a179 Implements strcasecmp() checker in Static Analyzer. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130398 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-04-28 15:09:11 +00:00
Lenny Maiorani 357f6ee9f1 Implements the strncmp() checker just like the strcmp() checker, but with bounds. Requires LLVM svn r129582. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130161 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-04-25 22:21:00 +00:00
Chris Lattner fc8f0e14ad fix a bunch of comment typos found by codespell. Patch by 
Luis Felipe Strano Moraes!



git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@129559 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-04-15 05:22:18 +00:00
Lenny Maiorani 318dd92ad8 This patch adds modeling of strcmp() to the CString checker. Validates inputs are not NULL and are real C strings, then does the comparison and binds the proper return value. Unit tests included. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@129364 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-04-12 17:08:43 +00:00
Lenny Maiorani 067bbd0e11 strcat() and strncat() model additions to CStringChecker. 
Validates inputs are not NULL, checks for overlapping strings, concatenates the strings checking for buffer overflow, sets the length of the destination string to the sum of the s1 length and the s2 length, binds the return value to the s1 value.



git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@129215 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-04-09 15:12:58 +00:00
Lenny Maiorani b8b875be7b Adding Static Analyzer checker for mempcpy(). 
Models mempcpy() so that if length is NULL the destination pointer is returned. Otherwise, the source and destination are confirmed not to be NULL and not overlapping. Finally the copy is validated to not cause a buffer overrun and the return value is bound to the address of the byte after the last byte copied.



git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@128677 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-03-31 21:36:53 +00:00
Argyrios Kyrtzidis ec8605f1d7 [analyzer] Rename CheckerV2 -> Checker. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@126726 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-03-01 01:16:21 +00:00
Argyrios Kyrtzidis 183ff98f42 [analyzer] Migrate CStringChecker to CheckerV2. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@126350 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-02-24 01:05:30 +00:00
Ted Kremenek 0ef473f754 Add CStringChecker support for strncpy. Patch by Lenny Maiorani! 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@126188 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-02-22 04:58:34 +00:00
Ted Kremenek be4242ce03 Add CStringChecker support for strnlen. Patch by Lenny Maiorani! 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@126187 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-02-22 04:55:05 +00:00
Argyrios Kyrtzidis 695fb50282 [analyzer] Pass CheckerManager to the registration functions. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@125777 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-02-17 21:39:17 +00:00
Chris Lattner 6810630bb0 simplify a bit. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@125724 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-02-17 05:38:27 +00:00
Argyrios Kyrtzidis a0decc9a24 [analyzer] Use the new registration mechanism on some of the experimental checks. These are: 
CStringChecker
   ChrootChecker
   MallocChecker
   PthreadLockChecker
   StreamChecker
   UnreachableCodeChecker

MallocChecker creates implicit dependencies between checkers and needs to be handled differently.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@125598 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-02-15 21:25:03 +00:00
Ted Kremenek 2534528c22 Rename 'InvalidateRegions()' to 'invalidateRegions()'. 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@125395 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-02-11 19:48:15 +00:00
Ted Kremenek 9b66371644 Split 'include/clang/StaticAnalyzer' into 'include/clang/StaticAnalyzer/Core' and 'include/clang/StaticAnalyzer/Checkers'. 
This layout matches lib/StaticAnalyzer, which corresponds to two StaticAnalyzer libraries.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@125251 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-02-10 01:03:03 +00:00
Argyrios Kyrtzidis af1a9330ff [analyzer] lib/StaticAnalyzer/Checkers/ExprEngineExperimentalChecks.h -> lib/StaticAnalyzer/Checkers/ExperimentalChecks.h 
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@125122 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-02-08 22:30:11 +00:00
Ted Kremenek e36de1fe51 Rename misc. methods in GRSubEngine to start 
with a lower-case letter.  No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@123211 91177308-0d34-0410-b5e6-96231b3b80d8
 2011-01-11 02:34:45 +00:00
Ted Kremenek 21142581d5 Chris Lattner has strong opinions about directory 
layout.  :)

Rename the 'EntoSA' directories to 'StaticAnalyzer'.

Internally we will still use the 'ento' namespace
for the analyzer engine (unless there are further
sabre rattlings...).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@122514 91177308-0d34-0410-b5e6-96231b3b80d8
 2010-12-23 19:38:26 +00:00