Commit Graph

7 Commits

Author SHA1 Message Date
Martin Storsjo 055b546734 [Driver] Don't add -dwarf-column-info when using -gcodeview on non-msvc targets
-dwarf-column-info is omitted if -gcodeview is specified for msvc
targets at the moment, but since -gcodeview is an option that can be
specified for any target, there's little reason to restrict this
handling to msvc targets.

This allows getting proper codeview debug info by passing -gcodeview
for e.g. MinGW targets as well.

Differential Revision: https://reviews.llvm.org/D46287

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@331807 91177308-0d34-0410-b5e6-96231b3b80d8
2018-05-08 20:55:23 +00:00
Shoaib Meenai 2e136b185e [Driver] Fix codeview-column-info on macOS
macOS home directory paths begin with /Users, and clang-cl interprets
the /U portion as a macro undefine rather than a path, causing test
failures on macOS. Use a -- to explicitly treat the input file as a path
and fix the test.

This effectively reverts r326168 and adds an alternative fix.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@326171 91177308-0d34-0410-b5e6-96231b3b80d8
2018-02-27 06:04:23 +00:00
Adam Nemet 88d94f2546 Attempt to fix greendragon bot after r326141
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@326168 91177308-0d34-0410-b5e6-96231b3b80d8
2018-02-27 04:49:26 +00:00
Reid Kleckner 5d63d85c91 Fix codeview-column-info.c test with a triple
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@326144 91177308-0d34-0410-b5e6-96231b3b80d8
2018-02-26 23:06:40 +00:00
Reid Kleckner 2cdcd07b15 Re-land "Emit proper CodeView when -gcodeview is passed without the cl driver."
Reverts r326116 and re-lands r326113 with a fix to ASan so that it
enables column info in its test suite.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@326141 91177308-0d34-0410-b5e6-96231b3b80d8
2018-02-26 22:55:33 +00:00
Zachary Turner 8890f6aaa0 Revert "Emit proper CodeView when -gcodeview is passed without the cl driver."
This reverts commit e17911006548518634fad66bb8648bcad49a1d64.

This is failing on ASAN bots because asan expects column info,
and it's also failing on some linux bots for unknown reasons which
i need to investigate.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@326116 91177308-0d34-0410-b5e6-96231b3b80d8
2018-02-26 19:51:29 +00:00
Zachary Turner 78e545f25d Emit proper CodeView when -gcodeview is passed without the cl driver.
Windows debuggers don't work properly when column info is emitted
with lines.  We handled this by checking if the driver mode was
cl, but it's possible to cause the gcc driver to emit codeview as
well, and in that path we were emitting column info with codeview.

Differential Revision: https://reviews.llvm.org/D43700

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@326113 91177308-0d34-0410-b5e6-96231b3b80d8
2018-02-26 19:25:39 +00:00