dnrops
/
clang
mirror of https://github.com/microsoft/clang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add missing check to warning for packed attribute. PR14259. 

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@167510 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Eli Friedman 2012-11-07 00:35:20 +00:00
parent cb7b45e6d8
commit b68ec6b7ff
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Sema/SemaDeclAttr.cpp
View File

@ -963,7 +963,8 @@ static void handlePackedAttr(Sema &S, Decl *D, const AttributeList &Attr) {
else if (FieldDecl *FD = dyn_cast<FieldDecl>(D)) {
// If the alignment is less than or equal to 8 bits, the packed attribute
// has no effect.
if (!FD->getType()->isIncompleteType() &&
if (!FD->getType()->isDependentType() &&
!FD->getType()->isIncompleteType() &&
S.Context.getTypeAlign(FD->getType()) <= 8)
S.Diag(Attr.getLoc(), diag::warn_attribute_ignored_for_field_of_type)
<< Attr.getName() << FD->getType();

9
test/SemaTemplate/instantiate-attr.cpp
View File

@ -25,3 +25,12 @@ namespace test1 {
int test1[__builtin_offsetof(type, a) == 0 ? 1 : -1];
int test2[__builtin_offsetof(type, b) == 4 ? 1 : -1];
}
namespace test2 {
template <class type>
struct fastscriptmember {
type Member __attribute__ ((packed));
char x;
};
int test0[sizeof(fastscriptmember<int>) == 5 ? 1 : -1];
}