dnrops
/
clang
mirror of https://github.com/microsoft/clang.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[analyzer] Fix crashes in CastToStruct checker for undefined structs 

This crash was reported in https://bugs.llvm.org//show_bug.cgi?id=31173

Differential Revision: https://reviews.llvm.org/D28297


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@297187 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Daniel Marjamaki 2017-03-07 19:20:48 +00:00
parent 28e06304a3
commit 0bdcd308fc
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/StaticAnalyzer/Checkers/CastToStructChecker.cpp
View File

@ -84,6 +84,10 @@ bool CastToStructVisitor::VisitCastExpr(const CastExpr *CE) {
if (!VD || VD->getType()->isReferenceType())
return true;
if (ToPointeeTy->isIncompleteType() ||
OrigPointeeTy->isIncompleteType())
return true;
// Warn when there is widening cast.
unsigned ToWidth = Ctx.getTypeInfo(ToPointeeTy).Width;
unsigned OrigWidth = Ctx.getTypeInfo(OrigPointeeTy).Width;

14
test/Analysis/cast-to-struct.cpp
View File

@ -65,3 +65,17 @@ void intToStruct(int *P) {
void *VP = P;
Abc = (struct ABC *)VP;
}
// https://llvm.org/bugs/show_bug.cgi?id=31173
void dontCrash1(struct AB X) {
struct UndefS *S = (struct UndefS *)&X;
}
struct S;
struct T {
struct S *P;
};
extern struct S Var1, Var2;
void dontCrash2() {
((struct T *) &Var1)->P = &Var2;
}