We also have a check in the plugin code but SwiftPM 5.9.1 and earlier
try to build some completely unsupported packages like swift-nio and
fail with a cryptic error message. Emitting a warning early on should
help users understand what's going on.
* Add WebDriverClient for headless testing
* Launch new session with headless arg by default
* Add --headless option in carton test
* Improve logging message
* Apply formatter for WebDriverClient module
* Support MS Edge
* Add headless testing test
* Explicitly depend on NIOFoundationCompat
* Avoid public actor field as a 5.5 compiler crash workaround
* Add --headless description in README.md
* Update Sources/CartonCLI/Commands/Test.swift
Co-authored-by: Max Desiatov <max@desiatov.com>
* Apply suggestions from code review for wording
Co-authored-by: Max Desiatov <max@desiatov.com>
* Rename failedToFindDriver -> failedToFindWebDriver
* Rephrase diagnostic message
* Omit explicit internal keyword
* Remove unused goto.Response struct
* Add license header to Tests/WebDriverClientTests/WebDriverClientTests.swift
Co-authored-by: Max Desiatov <max@desiatov.com>
Co-authored-by: Max Desiatov <max@desiatov.com>
* Use JSKit runtime from SwiftPM resources
* Fix Node.js test runner
* Remove unused webpack npm packages
* Update Swift version in `.swiftformat`
* Fix browser and Node.js CJS/ESM handling
* Fix one of the tests, add CI time limit
* Use Tokamak `update-jskit` branch to fix tests
* Use latest Vapor with `.mjs` content-type fix
* Use dynamic import to detect JSKit presence
* Fix missing `runtimeConstructor` reference
* Update `StaticArchive.swift`
* Reduce the diff
* Address PR feedback
* Fix Node.js <-> JSKit integration test
* Update SwiftPM dependencies
* Fix comment typo in `testNode.js`
* Reuse `__stack_sanitizer` across entrypoints
* Refactoring the use of `DestinationEnvironment` and `Environment`
`Environment` shouldn't specify the concrete environment, but the type
of environments enough for build planning.
* Lower i64 imports only for WASI oriented things
This makes our codebase smaller by ~80 lines and arguably more readable. Also removes OpenCombine dependency.
* Use `async`/`await` and actors instead of Combine
* Remove OpenCombine dependency
* Fix progress animation not updated
* Stop building with Swift 5.4, clean up terminal output
* Update requirements in `README.md`
* Add `description` to `InvalidResponseCode`
* Fix Linux build error
* Rename `main.swift` to `Main.swift`
* Work around IR/TDB warnings
* Pass IR/TDB arguments correctly to `swift build`
* Support `async` process runner in `carton-release`
* Use Xcode 13.2.1 on macOS
* Pass TDB/IR flags to `swift test` as well
* Make `Install` command async
* Add doc comments, handle subsequent rebuilds
Resolves#274.
* Statically link with `SwiftPMDataModel`
* Use 5.6 upstream branches in `Package.swift`
* Update Swift Argument Parser to 1.0.2
* Use latest SwiftPM 5.5
* Avoid copying non-existent `.so` in `Dockerfile`
Co-authored-by: Max Desiatov <max@desiatov.com>
Our `Dockerfile` should be updated to depend on SwiftWasm 5.5.
Additionally, Async HTTP Client has fixed the toolchain downloads issue in 1.8.1, I'm setting it as a minimum version in `Package.swift` here.
`async-http-client` package is now pinned to 1.6.4, as 1.7.0 and later versions caused issues with toolchain downloads (see https://github.com/swift-server/async-http-client/issues/488 for more details).
I've also updated toolchain downloader code to bubble up download errors, which previously were hidden and made it very hard to diagnose these issues.
* Use SwiftWasm 5.5.0, bump version to 0.12.0
* Pin AHC to 1.8.0
* Pin AHC to 1.6.4, always remove downloaded archives
* Fix `defer` build issue
I've dropped support for Swift 5.2, and SwiftLint now requires Xcode 12.5.1, which is unavailable on macOS 10.15 with GitHub Actions. This makes it impossible to test with Swift 5.3 on CI, so I'm bumping the required version to Swift 5.4.
Resolves https://github.com/swiftwasm/carton/issues/262.
* Update dependencies, add support for SwiftWasm 5.5
* Bump dependencies in `.github/workflows/swift.yml`
* Add explicit dependency on `NIOFoundationCompat`
* Lower Splash version to 0.15 for Swift 5.3 compat
* Update DefaultToolchain.swift
* Update swift.yml
* Revert "Lower Splash version to 0.15 for Swift 5.3 compat"
This reverts commit 6e04a7f158.
* Require Swift 5.4 in `Package.swift`
* Update README.md
* Use older 5.5 snapshot, unblock tests on failure
* Update DefaultToolchain.swift
* Select correct CPU architecture when downloading
* Disable hanging test
* Use latest 5.5 toolchain
* Use 2021-11-16 snapshot of SwiftWasm 5.5
* Add missing linker flags, re-enable browser test
* Address PR feedback
* Bump version to 0.11.0, update dependencies
* Test on Big Sur with Xcode 12.5
* Update test fixture dependencies
* Remove `LinuxMain.swift` expectations
* Test with `wasm-5.4-SNAPSHOT-2021-08-26-a`
* Remove expectations for `XCTestManifests.swift`
* Enable debugging output
* Try the latest 5.4 toolchain
* print debug output
* More debug output
* Test on macOS 11 with Xcode 13
* Pipe errors to stdout
* Update DefaultToolchain.swift
* Revert "Update DefaultToolchain.swift"
This reverts commit 4ff15f938a.
* Remove Xcode 13 from the CI matrix
* Update DefaultToolchain.swift
* Reduce the diff
Previously, the file we need to include with the build to enable the stack overflow sanitizer was written as a temporary file. This didn't happen though on watcher rebuilds with `carton dev` and caused crashes when a code line containing `try!` relying on this file to be present was executed.
I think it's easier and more efficient to bundle this file in the `static.zip` file that already includes our JS entrypoints. We require `static.zip` to be downloaded and unpacked successfully into `~/.carton/static` before every build anyway. It makes more sense to sense the sanitizer file in `~/.carton/static/so_sanitizer.wasm` and use that instead writing and deleting it at a temporary path on every build.
I've also updated the JSKit dependency and cleaned up some linter warnings by moving large tuple values into a separate `BuildDescription` type.
* Use libSwiftPM instead of custom model types #120
* Update SwiftPM dependencies
* Add wrapper to handle discrepancy between encoded and decoded Manifest
* Try to fix 5.2 dependency resolving
* Try to fix 5.2 dependency resolving
Co-authored-by: Max Desiatov <max@desiatov.com>
* carton dev and bundle default command tests
* removed tests_output
* removed .testfile
* carton dev and bundle default command tests
* removed localhost as localURL
* attempt to fix folder name issue
* removed Fixtures test folder
* added Fixtures test folder
* attempt to fix folder name issue
* attempt to fix server connect issue
* fixed dev testWithNoArguments with sleep delay
* Debugging bundle command for github actions
* Install wasmr prior to swift test
* Debug clean up
* Debug clean up
* Update Tests/CartonCommandTests/CommandTestHelper.swift
Co-authored-by: Max Desiatov <max@desiatov.com>
Co-authored-by: thecb4 <cavelle@tehcb4.io>
Co-authored-by: Max Desiatov <max@desiatov.com>
* Added Dev tests and fixed hard coded paths, fixes#183
* Fixed Path dependency in 5.2 Package
* Removed mxcl/Path dependency
* Removed mxcl/Path dependency, Added confirmation of file existence in Init test
* Added sdk install head of init command test
* Moved carton sdk install to static setup method for tests
* Moved carton sdk install to static setup method for tests
* Moved carton sdk install to static setup method for tests
* Moved carton sdk install to static setup method for tests
* Moved carton sdk install to static setup method for tests
* changed order of actions for github automations to support testing
* modified test run to exclude release
* changed sdk install to run per test
* adjusted github workflows to create carton sdk folders
* adjusted github workflows to use /home/runner instead of root
* adjusted test to wait for sdk installation
* adjusted ubuntu tests for passing
* adjusted Dockerfile to run tests
* added tmate session for debugging
* Removed tmate session, added directory creation for carton sdk and sym link
* Adjusted order of commands for runner
* Fixed mkdir from worker to runner
* Added more terminal output for debugging
* Added more terminal output for debugging
* Added more terminal output for debugging
* Added more terminal output for debugging
* Added more terminal output for debugging
* Fixed hard coded paths
* Removed test investigation fixtures
* Removed test investigation fixtures
Co-authored-by: thecb4 <cavelle@tehcb4.io>
* Changed sources folder to separate the CLI from the 'Kit' to allow for testability of each command
* Fixed Swift 5.2 Support
* Removed Path.swift (for now)
* Fixed OpenCombine and other version issues for 5.2 support
* Removed Path.swift from test target dependency
Co-authored-by: thecb4 <cavelle@tehcb4.io>
`FileDownloadDelegate` was introduced in https://github.com/swift-server/async-http-client/pull/275, which almost directly mirrors the implementation in `carton`. Now that it's available in a released version of AHC, let's delete some code here and replace it with the version from that package.
In the latest 5.3 toolchain all known issues with IndexStoreDB and SwiftPM support were resolved.
Resolves the second point of #42.
Thanks to this you no longer need to maintain `LinuxMain.swift` and `XCTestManifests.swift` files in your test suites, so these are deleted from the test app `Tests` directory.
TTY terminal output is unavailable on CI, or when users redirect output to a file or a pipe. In those cases `TerminalController` initializer returns `nil`. SwiftPM has a wrapper `InteractiveWriter` class for it, which writes output to stdout directly in that case. I've copied that, and replaced all uses of `TerminalController` with it. A VSCode task is added to test that.
In my testing it looks like download progress reporting is quite spammy, so it now has `removeDuplicates` Combine operator added to make it output only when values differ significantly from each other.
Additionally, SDK installs can hit GitHub API rate limit on CI nodes, so `carton` now reads `GITHUB_TOKEN` environment variable, which gives much higher limits to authenticated API users.
We can now also run various `carton` commands on CI for basic end-to-end testing.
Resolves#112.
The latest SwiftWasm 5.3 snapshot requires users to use `import WASILibc` instead of `import Glibc`. This makes differences between platforms more explicit.
dnrops
omochimetaru