fix: Subscription message handling - serial queue and stop after failed event

AppSyncRealTimeClient/Connection/AppSyncConnection/AppSyncSubscriptionConnection+ErrorHandler.swift

@@ -32,6 +32,7 @@ extension AppSyncSubscriptionConnection {
             let connectionError = error as? ConnectionProviderError
         else {
             subscriptionItem.subscriptionEventHandler(.failed(error), subscriptionItem)
+            connectionProvider?.removeListener(identifier: subscriptionItem.identifier)
             return
         }
 
@@ -43,6 +44,7 @@ extension AppSyncSubscriptionConnection {
             }
         } else {
             subscriptionItem.subscriptionEventHandler(.failed(error), subscriptionItem)
+            connectionProvider?.removeListener(identifier: subscriptionItem.identifier)
         }
     }
 

AppSyncRealTimeClient/Connection/AppSyncConnection/AppSyncSubscriptionConnection.swift

@@ -28,6 +28,10 @@ public class AppSyncSubscriptionConnection: SubscriptionConnection, RetryableCon
     /// Retry logic to handle
     var retryHandler: ConnectionRetryHandler?
 
+    let serialQueue = DispatchQueue(
+        label: "com.amazonaws.AppSyncSubscriptionConnection.serialQueue"
+    )
+
     public init(provider: ConnectionProvider) {
         self.connectionProvider = provider
     }
@@ -84,13 +88,15 @@ public class AppSyncSubscriptionConnection: SubscriptionConnection, RetryableCon
                 AppSyncLogger.debug("[AppSyncSubscriptionConnection] \(#function): Self is nil, listener is not called.")
                 return
             }
-            switch event {
+            self.serialQueue.async {
-            case .connection(let state):
+                switch event {
-                self.handleConnectionEvent(connectionState: state)
+                case .connection(let state):
-            case .data(let response):
+                    self.handleConnectionEvent(connectionState: state)
-                self.handleDataEvent(response: response)
+                case .data(let response):
-            case .error(let error):
+                    self.handleDataEvent(response: response)
-                self.handleError(error: error)
+                case .error(let error):
+                    self.handleError(error: error)
+                }
             }
         }
     }