dnrops
/
Tokamak
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update script injection code in `README.md` (#332) 

This code had a missing `document` reference, and was plain outdated and not working with the latest version of JavaScriptKit.

Also, it turns out that `insertAdjacentHTML` does not work for script injection, although it does seem to work for styles injection. Separate `createElement`, `setAttribute`, and `appendChild` calls do seem to work for scripts.
This commit is contained in:
Max Desiatov 2020-12-19 15:28:30 +00:00 committed by GitHub
parent ba17b79b1d
commit 3c97be617a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
README.md
View File

@ -91,10 +91,12 @@ DOM access:
```swift ```swift
import JavaScriptKit import JavaScriptKit
_ = document.head.object!.insertAdjacentHTML!("beforeend", #""" let document = JSObject.global.document
<script src="https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.27.0/moment.min.js"></script> let script = document.createElement("script")
"""#) script.setAttribute("src", "https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.27.0/moment.min.js")
_ = document.head.object!.insertAdjacentHTML!("beforeend", #""" document.head.appendChild(script)
_ = document.head.insertAdjacentHTML("beforeend", #"""
<link <link
rel="stylesheet" rel="stylesheet"
href="https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.4.1/semantic.min.css"> href="https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.4.1/semantic.min.css">