SwiftLint/Source/SwiftLintFramework/Rules/Metrics/CyclomaticComplexityRule.swift

101 lines
4.2 KiB
Swift

import Foundation
import SourceKittenFramework
public struct CyclomaticComplexityRule: ASTRule, ConfigurationProviderRule {
public var configuration = CyclomaticComplexityConfiguration(warning: 10, error: 20)
public init() {}
public static let description = RuleDescription(
identifier: "cyclomatic_complexity",
name: "Cyclomatic Complexity",
description: "Complexity of function bodies should be limited.",
kind: .metrics,
nonTriggeringExamples: [
"func f1() {\nif true {\nfor _ in 1..5 { } }\nif false { }\n}",
"func f(code: Int) -> Int {" +
"switch code {\n case 0: fallthrough\ncase 0: return 1\ncase 0: return 1\n" +
"case 0: return 1\ncase 0: return 1\ncase 0: return 1\ncase 0: return 1\n" +
"case 0: return 1\ncase 0: return 1\ndefault: return 1}}",
"func f1() {" +
"if true {}; if true {}; if true {}; if true {}; if true {}; if true {}\n" +
"func f2() {\n" +
"if true {}; if true {}; if true {}; if true {}; if true {}\n" +
"}}"
],
triggeringExamples: [
"↓func f1() {\n if true {\n if true {\n if false {}\n }\n" +
" }\n if false {}\n let i = 0\n\n switch i {\n case 1: break\n" +
" case 2: break\n case 3: break\n case 4: break\n default: break\n }\n" +
" for _ in 1...5 {\n guard true else {\n return\n }\n }\n}\n"
]
)
public func validate(file: SwiftLintFile, kind: SwiftDeclarationKind,
dictionary: SourceKittenDictionary) -> [StyleViolation] {
guard SwiftDeclarationKind.functionKinds.contains(kind) else {
return []
}
let complexity = measureComplexity(in: file, dictionary: dictionary)
for parameter in configuration.params where complexity > parameter.value {
let offset = dictionary.offset ?? 0
let reason = "Function should have complexity \(configuration.length.warning) or less: " +
"currently complexity equals \(complexity)"
return [StyleViolation(ruleDescription: type(of: self).description,
severity: parameter.severity,
location: Location(file: file, byteOffset: offset),
reason: reason)]
}
return []
}
private func measureComplexity(in file: SwiftLintFile, dictionary: SourceKittenDictionary) -> Int {
var hasSwitchStatements = false
let complexity = dictionary.substructure.reduce(0) { complexity, subDict in
guard subDict.kind != nil else {
return complexity
}
if let declarationKind = subDict.declarationKind,
SwiftDeclarationKind.functionKinds.contains(declarationKind) {
return complexity
}
guard let statementKind = subDict.statementKind else {
return complexity + measureComplexity(in: file, dictionary: subDict)
}
if statementKind == .switch {
hasSwitchStatements = true
}
let score = configuration.complexityStatements.contains(statementKind) ? 1 : 0
return complexity +
score +
measureComplexity(in: file, dictionary: subDict)
}
if hasSwitchStatements && !configuration.ignoresCaseStatements {
return reduceSwitchComplexity(initialComplexity: complexity, file: file, dictionary: dictionary)
}
return complexity
}
// Switch complexity is reduced by `fallthrough` cases
private func reduceSwitchComplexity(initialComplexity complexity: Int, file: SwiftLintFile,
dictionary: SourceKittenDictionary) -> Int {
let bodyOffset = dictionary.bodyOffset ?? 0
let bodyLength = dictionary.bodyLength ?? 0
let contents = file.stringView.substringWithByteRange(start: bodyOffset, length: bodyLength) ?? ""
let fallthroughCount = contents.components(separatedBy: "fallthrough").count - 1
return complexity - fallthroughCount
}
}