dnrops
/
SwiftLint
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use `is` instead of `as` for simple type checks

This commit is contained in:
Danny Mösch 2023-03-12 11:37:53 +01:00
parent a2facce70c
commit cf1e2e27dc
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Source/SwiftLintFramework/Rules/Style/PreferSelfInStaticReferencesRule.swift
View File

@ -305,12 +305,12 @@ private class Visitor: ViolationsSyntaxVisitor {
override func visitPost(_ node: IdentifierExprSyntax) { override func visitPost(_ node: IdentifierExprSyntax) {
guard let parent = node.parent, guard let parent = node.parent,
parent.as(SpecializeExprSyntax.self) == nil, !parent.is(SpecializeExprSyntax.self),
parent.as(DictionaryElementSyntax.self) == nil, !parent.is(DictionaryElementSyntax.self),
parent.as(ArrayElementSyntax.self) == nil else { !parent.is(ArrayElementSyntax.self) else {
return return
} }
if parent.as(FunctionCallExprSyntax.self) != nil, case .likeClass(_, false) = parentDeclScopes.last { if parent.is(FunctionCallExprSyntax.self), case .likeClass(_, false) = parentDeclScopes.last {
return return
} }
addViolation(on: node.identifier) addViolation(on: node.identifier)
@ -362,7 +362,7 @@ private class Visitor: ViolationsSyntaxVisitor {
} }
override func visitPost(_ node: SimpleTypeIdentifierSyntax) { override func visitPost(_ node: SimpleTypeIdentifierSyntax) {
if node.parent?.as(KeyPathExprSyntax.self) != nil { if node.parent?.is(KeyPathExprSyntax.self) == true {
addViolation(on: node.name) addViolation(on: node.name)
} }
} }