dnrops
/
SwiftLint
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up unused initializers (#4726) 

Found with the upcoming improve dead code detection.
This commit is contained in:
JP Simard 2023-01-27 16:31:56 -05:00 committed by GitHub
parent 9ac13f078a
commit 84c6d200b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Source/SwiftLintFramework/Extensions/Configuration+FileGraph.swift
View File

@ -28,14 +28,6 @@ public extension Configuration {
self.ignoreParentAndChildConfigs = ignoreParentAndChildConfigs
}
internal init(config: String, rootDirectory: String, ignoreParentAndChildConfigs: Bool) throws {
self.init(
commandLineChildConfigs: [config],
rootDirectory: rootDirectory,
ignoreParentAndChildConfigs: ignoreParentAndChildConfigs
)
}
/// Dummy init to get a FileGraph that just represents a root directory
internal init(rootDirectory: String) {
self.init(

39
Source/swiftlint/Helpers/LintableFilesVisitor.swift
View File

@ -83,25 +83,6 @@ struct LintableFilesVisitor {
let mode: LintOrAnalyzeModeWithCompilerArguments
let block: (CollectedLinter) async -> Void
init(paths: [String], action: String, useSTDIN: Bool,
quiet: Bool, showProgressBar: Bool, useScriptInputFiles: Bool, forceExclude: Bool, useExcludingByPrefix: Bool,
cache: LinterCache?, parallel: Bool,
allowZeroLintableFiles: Bool, block: @escaping (CollectedLinter) async -> Void) {
self.paths = resolveParamsFiles(args: paths)
self.action = action
self.useSTDIN = useSTDIN
self.quiet = quiet
self.showProgressBar = showProgressBar
self.useScriptInputFiles = useScriptInputFiles
self.forceExclude = forceExclude
self.useExcludingByPrefix = useExcludingByPrefix
self.cache = cache
self.parallel = parallel
self.mode = .lint
self.allowZeroLintableFiles = allowZeroLintableFiles
self.block = block
}
private init(paths: [String], action: String, useSTDIN: Bool, quiet: Bool, showProgressBar: Bool,
useScriptInputFiles: Bool, forceExclude: Bool, useExcludingByPrefix: Bool,
cache: LinterCache?, compilerInvocations: CompilerInvocations?,
@ -142,15 +123,17 @@ struct LintableFilesVisitor {
compilerInvocations = try loadCompilerInvocations(options)
}
return Self(paths: options.paths, action: options.verb.bridge().capitalized,
useSTDIN: options.useSTDIN, quiet: options.quiet,
showProgressBar: options.progress,
useScriptInputFiles: options.useScriptInputFiles,
forceExclude: options.forceExclude,
useExcludingByPrefix: options.useExcludingByPrefix,
cache: cache,
compilerInvocations: compilerInvocations,
allowZeroLintableFiles: allowZeroLintableFiles, block: block)
return LintableFilesVisitor(
paths: options.paths, action: options.verb.bridge().capitalized,
useSTDIN: options.useSTDIN, quiet: options.quiet,
showProgressBar: options.progress,
useScriptInputFiles: options.useScriptInputFiles,
forceExclude: options.forceExclude,
useExcludingByPrefix: options.useExcludingByPrefix,
cache: cache,
compilerInvocations: compilerInvocations,
allowZeroLintableFiles: allowZeroLintableFiles, block: block
)
}
}