dnrops
/
SwiftLint
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix false positives in `sorted_first_last` rule when `first`/`last` have a predicate (#5038)

This commit is contained in:
woxtu 2023-06-12 00:22:06 +09:00 committed by GitHub
parent 43190834c5
commit 156f6aabc8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -42,6 +42,11 @@
[Haoocen](https://github.com/Haoocen) [Haoocen](https://github.com/Haoocen)
[#5023](https://github.com/realm/SwiftLint/pull/5023) [#5023](https://github.com/realm/SwiftLint/pull/5023)
* Fix false positives on `sorted_first_last` rule when `first`/`last` have
a predicate.
[woxtu](https://github.com/woxtu)
[#3023](https://github.com/realm/SwiftLint/issues/3023)
## 0.52.2: Crisper Clearer Pleats ## 0.52.2: Crisper Clearer Pleats
#### Breaking #### Breaking

7
Source/SwiftLintBuiltInRules/Rules/Performance/SortedFirstLastRule.swift
View File

@ -21,7 +21,11 @@ struct SortedFirstLastRule: SwiftSyntaxRule, OptInRule, ConfigurationProviderRul
Example("myList.sorted().firstIndex(where: someFunction)"), Example("myList.sorted().firstIndex(where: someFunction)"),
Example("myList.sorted().lastIndex(where: someFunction)"), Example("myList.sorted().lastIndex(where: someFunction)"),
Example("myList.sorted().firstIndex { $0 == key }"), Example("myList.sorted().firstIndex { $0 == key }"),
Example("myList.sorted().lastIndex { $0 == key }") Example("myList.sorted().lastIndex { $0 == key }"),
Example("myList.sorted().first(where: someFunction)"),
Example("myList.sorted().last(where: someFunction)"),
Example("myList.sorted().first { $0 == key }"),
Example("myList.sorted().last { $0 == key }")
], ],
triggeringExamples: [ triggeringExamples: [
Example("↓myList.sorted().first\n"), Example("↓myList.sorted().first\n"),
@ -50,6 +54,7 @@ private extension SortedFirstLastRule {
override func visitPost(_ node: MemberAccessExprSyntax) { override func visitPost(_ node: MemberAccessExprSyntax) {
guard guard
node.name.text == "first" || node.name.text == "last", node.name.text == "first" || node.name.text == "last",
node.parent?.is(FunctionCallExprSyntax.self) != true,
let firstBase = node.base?.asFunctionCall, let firstBase = node.base?.asFunctionCall,
let firstBaseCalledExpression = firstBase.calledExpression.as(MemberAccessExprSyntax.self), let firstBaseCalledExpression = firstBase.calledExpression.as(MemberAccessExprSyntax.self),
firstBaseCalledExpression.name.text == "sorted", firstBaseCalledExpression.name.text == "sorted",