llvm-project/libcxx/test/std
Eric Fiselier 70192a9efb [libcxx] Rewrite C++03 __invoke.
Summary:
This patch rewrites the C++03 `__invoke` and related meta-programming. There are a number of major changes.

`__invoke` in C++03 now has a fallback overload for when the invoke expression is ill-formed (similar to C++11). This means that the `__invoke_return` traits will return `__nat` when `__invoke(...)` is ill formed. This would previously cause a compile error.

Bullets 1-4 of `__invoke` have been rewritten. In the old version `__invoke` had 32 overloads for bullets 1 and 2,
one for each possible cv-qualified function signature with arities 0-3. 64 overloads would be needed to support member functions
with varargs. Currently these overloads were fundamentally broken. An example overload looked like:
```
template <class Rp, class Tp, class T1, class A0>
Rp __invoke(Rp (Tp::*pm)(A0) const, T1&, A0&)
```
Because `A0` appeared in two different deducible contexts it would have to deduce to be an exact match or the overload
would be rejected. This is made even worse because `A0` appears without a reference qualifier in the member function signature
and with a reference qualifier as an `__invoke` parameter. This means that only member functions that took all
of their arguments by value could be matched.

One possible fix would be to make the second occurrence of `A0` appear in a non-deducible context. This way
any type convertible to `A0` could be passed as the first parameter. The benefit of this approach is that the
signature of the member function enforces the arity and types taken by the `__invoke` signature it generates. However
nothing in the `INVOKE` specification requires this behavior.

My solution is to use a `__invoke_enable_if<PM_Type, Tp>`  metafunction to selectively enable the `__invoke` overloads for bullets 1, 2, 3 and 4.  It uses `__member_function_traits` to inspect and extract the return type and class type of the pointer to member. Using `__member_function_traits` to inspect `PM_Type` also allows us to reduce the number of `__invoke` overloads from 32 to 8 and add
varargs support at the same time.

Because `__invoke_enable_if` knows the exact return type of `__invoke` for bullets 1-4 we no longer need to use `decltype(__invoke(...))` to
compute the return type in the `__invoke_return*` traits. This will reduce the problems caused by `#define decltype(X) __typeof__(X)` in C++03.

Tests for this change have already been committed. All tests in `test/std/utilities/function.objects` now pass in C++03, previously there were 20 failures.

Reviewers: K-ballo, howard.hinnant, mclow.lists

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D11553

llvm-svn: 246068
2015-08-26 20:15:02 +00:00
..
algorithms Change some #ifdefs to #if - thanks to Dexon for thge catch. 2015-07-30 13:56:00 +00:00
atomics Misc drive-by cleanups. NFC 2015-08-24 21:20:07 +00:00
containers Recommit rL245802: Cleanup fancy pointer rebinding in list using __rebind_pointer. 2015-08-23 02:56:05 +00:00
depr Cleanup warnings in test/std/depr 2015-07-18 22:51:51 +00:00
diagnostics Fix warnings in array and assoc containers 2015-07-18 23:56:04 +00:00
experimental [libcxx] Add <experimental/any> v2. 2015-07-31 02:24:58 +00:00
extensions Fix more issues exposed by -pedantic-errors in c++03 mode 2015-02-10 17:20:18 +00:00
input.output Fix up typos in a couple of tests; due to agressive short-circuiting, they never failed on clang or gcc, but MSVC whined. Patch by Andrew Parker. 2015-07-18 18:24:15 +00:00
iterators A few bits of N2994 didn't get fully implemented a long time ago. Thanks to STL@microsoft.com for the bug report 2015-04-16 21:36:54 +00:00
language.support Fix a handful of tests that fail in C++03 2015-07-28 07:31:50 +00:00
localization Remove XFAIL in test. The bug causing it has been fixed. 2015-08-26 07:03:43 +00:00
numerics Remove unneeded initialisation of fenv_t and fexcept_t. 2015-03-15 18:36:31 +00:00
re Fix a crasher found by libFuzzer 2015-08-24 15:57:09 +00:00
strings implement more of N4258 - Cleaning up noexcept in the standard library. Specifically add new noexcept stuff to vector and string's move-assignment operations 2015-08-18 18:57:00 +00:00
thread Refactor flaky shared_mutex tests 2015-08-26 19:04:40 +00:00
utilities [libcxx] Rewrite C++03 __invoke. 2015-08-26 20:15:02 +00:00
nothing_to_do.pass.cpp