From ec402f1d5da02dfbdc87d031ff99d7dbcada336f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Wed, 12 May 2021 22:43:13 +0300 Subject: [PATCH] [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into UNSUPPORTED This particular test relies on internal details from the libc++ filesystem implementation header, and those details are structured differently in the implementation for Windows. Differential Revision: https://reviews.llvm.org/D102357 --- .../directory_entry.mods/last_write_time.pass.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp b/libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp index 44f90b019223..49a5168c3855 100644 --- a/libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp +++ b/libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp @@ -9,7 +9,11 @@ // UNSUPPORTED: c++03 // ADDITIONAL_COMPILE_FLAGS: -I %S/../../../../../../src/filesystem -// XFAIL: LIBCXX-WINDOWS-FIXME +// This test relies on calling functions from the libcxx internal header +// filesystem_common.h; the Windows implementation uses different +// internals and doesn't provide the same set_file_times function as for +// other platforms. +// UNSUPPORTED: windows //