OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 2
Code Issues Packages Projects Releases Wiki Activity

[Bitcode] Fix size check for DIImportedEntity record 

This was using && instead of ||.
This commit is contained in:
Nikita Popov 2022-02-09 14:19:24 +01:00
parent 72248712e5
commit ea93ca60ef
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Bitcode/Reader/MetadataLoader.cpp
View File

@ -2033,8 +2033,8 @@ Error MetadataLoader::MetadataLoaderImpl::parseOneMetadata(
break;
}
case bitc::METADATA_IMPORTED_ENTITY: {
if (Record.size() < 6 && Record.size() > 8)
return error("Invalid record");
if (Record.size() < 6 || Record.size() > 8)
return error("Invalid DIImportedEntity record");
IsDistinct = Record[0];
bool HasFile = (Record.size() >= 7);

BIN
llvm/test/Bitcode/Inputs/invalid-diimportedentity-record.bc Normal file
View File

Binary file not shown.

5
llvm/test/Bitcode/invalid.test
View File

@ -286,3 +286,8 @@ RUN: not llvm-dis -disable-output %p/Inputs/invalid-chunk-size.bc 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-CHUNK-SIZE %s
INVALID-CHUNK-SIZE: Fixed or VBR abbrev record with size > MaxChunkData
RUN: not llvm-dis -disable-output %p/Inputs/invalid-diimportedentity-record.bc 2>&1 | \
RUN: FileCheck --check-prefix=INVALID-DIIMPORTEDENTITY-RECORD %s
INVALID-DIIMPORTEDENTITY-RECORD: Invalid DIImportedEntity record