OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 2
Code Issues Packages Projects Releases Wiki Activity

[mlir] Update Python CMake version requirement. 

The minimum required version is now 3.19 due to the usage of some
more recent features. Update the version check and error message
accordingly. Also remove some logic that behaved differently before
3.18, since we can assume we are now on version 3.19+.

Reviewed By: stella.stamenova

Differential Revision: https://reviews.llvm.org/D130171
This commit is contained in:
Mike Urbach 2022-07-20 08:21:36 -06:00
parent 3bbd380a5b
commit e0af5032f1
1 changed files with 13 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
mlir/cmake/modules/MLIRDetectPythonEnv.cmake
View File

@ -2,27 +2,13 @@
# Finds and configures python packages needed to build MLIR Python bindings.
macro(mlir_configure_python_dev_packages)
if(CMAKE_VERSION VERSION_LESS "3.15.0")
if(CMAKE_VERSION VERSION_LESS "3.19.0")
message(SEND_ERROR
"Building MLIR Python bindings is known to rely on CMake features "
"that require at least version 3.15. Recommend upgrading to 3.18+ "
"that require at least version 3.19. Recommend upgrading to 3.19+ "
"for full support. Detected current version: ${CMAKE_VERSION}")
endif()
# After CMake 3.18, we are able to limit the scope of the search to just
# Development.Module. Searching for Development will fail in situations where
# the Python libraries are not available. When possible, limit to just
# Development.Module.
# See https://pybind11.readthedocs.io/en/stable/compiling.html#findpython-mode
if(CMAKE_VERSION VERSION_LESS "3.18.0")
message(WARNING
"This version of CMake is not compatible with statically built Python "
"installations. If Python fails to detect below this may apply to you. "
"Recommend upgrading to at least CMake 3.18. "
"Detected current version: ${CMAKE_VERSION}"
)
set(_python_development_component Development)
else()
if(MLIR_DETECT_PYTHON_ENV_PRIME_SEARCH)
# Prime the search for python to see if there is a full development
# package. This seems to work around cmake bugs searching only for
@ -31,8 +17,14 @@ macro(mlir_configure_python_dev_packages)
find_package(Python3 ${LLVM_MINIMUM_PYTHON_VERSION}
COMPONENTS Interpreter Development)
endif()
# After CMake 3.18, we are able to limit the scope of the search to just
# Development.Module. Searching for Development will fail in situations where
# the Python libraries are not available. When possible, limit to just
# Development.Module.
# See https://pybind11.readthedocs.io/en/stable/compiling.html#findpython-mode
set(_python_development_component Development.Module)
endif()
find_package(Python3 ${LLVM_MINIMUM_PYTHON_VERSION}
COMPONENTS Interpreter ${_python_development_component} NumPy REQUIRED)
unset(_python_development_component)