OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 2
Code Issues Packages Projects Releases Wiki Activity

Fix patch not passing test cases 

llvm-svn: 365170
This commit is contained in:
Alex Brachet 2019-07-05 01:28:41 +00:00
parent 3d0193909b
commit de7da3f694
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/test/tools/llvm-objcopy/ELF/respect-umask.test
View File

@ -19,20 +19,19 @@
# RUN: chmod 0777 %t # RUN: chmod 0777 %t
# RUN: llvm-objcopy %t %t1 # RUN: llvm-objcopy %t %t1
# RUN: ls -l %t1 | cut -f 1 -d ' ' > %t1.perms # RUN: ls -l %t1 | cut -f 1 -d ' ' > %t1.perms
## : cmp %t1.perms %t.0755 # RUN: cmp %t1.perms %t.0755
# RUN: umask 0237 # RUN: umask 0237
# RUN: chmod 0707 %t # RUN: chmod 0707 %t
# RUN: llvm-objcopy %t %t1 # RUN: llvm-objcopy %t %t1
# RUN: ls -l %t1 | cut -f 1 -d ' ' > %t1.perms # RUN: ls -l %t1 | cut -f 1 -d ' ' > %t1.perms
## : cmp %t1.perms %t.0500 # RUN: cmp %t1.perms %t.0500
# RUN: umask 0222 # RUN: umask 0222
# RUN: chmod 0777 %t # RUN: chmod 0777 %t
# RUN: llvm-objcopy %t %t1 # RUN: llvm-objcopy %t %t1
# RUN: ls -l %t1 | cut -f 1 -d ' ' > %t1.perms # RUN: ls -l %t1 | cut -f 1 -d ' ' > %t1.perms
## : cmp %t1.perms %t.0555 # RUN: cmp %t1.perms %t.0555
--- !ELF --- !ELF
FileHeader: FileHeader:

3
llvm/tools/llvm-objcopy/llvm-objcopy.cpp
View File

@ -215,7 +215,8 @@ static Error restoreStatOnFile(StringRef Filename,
FD, Stat.getLastAccessedTime(), Stat.getLastModificationTime())) FD, Stat.getLastAccessedTime(), Stat.getLastModificationTime()))
return createFileError(Filename, EC); return createFileError(Filename, EC);
if (auto EC = sys::fs::setPermissions(Filename, Stat.permissions())) if (auto EC = sys::fs::setPermissions(Filename, Stat.permissions(),
/*respectUmask=*/true))
return createFileError(Filename, EC); return createFileError(Filename, EC);
if (auto EC = sys::Process::SafelyCloseFileDescriptor(FD)) if (auto EC = sys::Process::SafelyCloseFileDescriptor(FD))