OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 2
Code Issues Packages Projects Releases Wiki Activity

[tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c 

Looks like non-x86 bots are unhappy with inclusion of <stdatomic.h>
e.g.:

clang-armv7-vfpv3-2stage - https://lab.llvm.org/buildbot/#/builders/182/builds/626
clang-ppc64le-linux - https://lab.llvm.org/buildbot/#/builders/76/builds/3619
llvm-clang-win-x-armv7l - https://lab.llvm.org/buildbot/#/builders/60/builds/4514

It seems to be unnecessary, just remove it and replace atomic_load()
calls with dereferences of _Atomic*.

Differential Revision: https://reviews.llvm.org/D108555
This commit is contained in:
Alexander Potapenko 2021-08-23 15:46:28 +02:00
parent f3671a688d
commit cdb391698b
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clang/test/CodeGen/sanitize-thread-disable.c
View File

@ -1,8 +1,6 @@
// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - %s | FileCheck -check-prefixes CHECK,WITHOUT %s
// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -o - %s -fsanitize=thread | FileCheck -check-prefixes CHECK,TSAN %s
#include <stdatomic.h>
// Instrumented function.
// TSan inserts calls to __tsan_func_entry() and __tsan_func_exit() to prologue/epilogue.
// Non-atomic loads are instrumented with __tsan_readXXX(), atomic loads - with
@ -19,7 +17,7 @@
// WITHOUT-NOT: call void @__tsan_func_exit
// CHECK: ret i32
int instrumented1(int *a, _Atomic int *b) {
return *a + atomic_load(b);
return *a + *b;
}
// Function with no_sanitize("thread").
@ -37,7 +35,7 @@ int instrumented1(int *a, _Atomic int *b) {
// WITHOUT-NOT: call void @__tsan_func_exit
// CHECK: ret i32
__attribute__((no_sanitize("thread"))) int no_false_positives1(int *a, _Atomic int *b) {
return *a + atomic_load(b);
return *a + *b;
}
// Function with disable_sanitizer_instrumentation: no instrumentation at all.
@ -53,5 +51,5 @@ __attribute__((no_sanitize("thread"))) int no_false_positives1(int *a, _Atomic i
// WITHOUT-NOT: call void @__tsan_func_exit
// CHECK: ret i32
__attribute__((disable_sanitizer_instrumentation)) int no_instrumentation1(int *a, _Atomic int *b) {
return *a + atomic_load(b);
return *a + *b;
}