OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 2
Code Issues Packages Projects Releases Wiki Activity

[BOLT][NFC] Fix possible use-after-free 

If NewName twine has reference to the old name, then after
Section.Name = NewName.str(); this reference is invalidated,
so we cannot use NewName.str() anymore.

Reviewed By: rafauler

Differential Revision: https://reviews.llvm.org/D137616
This commit is contained in:
revunov.denis@huawei.com 2022-11-14 13:25:20 +00:00
parent 044fcfa1ed
commit c92ff2a3c4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bolt/lib/Core/BinaryContext.cpp
View File

@ -2036,9 +2036,9 @@ void BinaryContext::renameSection(BinarySection &Section,
deregisterSectionName(Section);
Section.Name = NewName.str();
Section.setOutputName(NewName);
Section.setOutputName(Section.Name);
NameToSection.insert(std::make_pair(NewName.str(), &Section));
NameToSection.insert(std::make_pair(Section.Name, &Section));
// Reinsert with the new name.
Sections.insert(&Section);