Use value instead of getValue (NFC)

bolt/unittests/Core/MCPlusBuilder.cpp

@@ -142,7 +142,7 @@ TEST_P(MCPlusBuilderTester, Annotation) {
   // Round-trip encoding-decoding check for negative values
   Optional<MCPlus::MCLandingPad> EHInfo = BC->MIB->getEHInfo(Inst);
   ASSERT_TRUE(EHInfo.has_value());
-  MCPlus::MCLandingPad LP = EHInfo.getValue();
+  MCPlus::MCLandingPad LP = EHInfo.value();
   uint64_t DecodedValue = LP.second;
   ASSERT_EQ(Value, DecodedValue);
 

clang/utils/TableGen/RISCVVEmitter.cpp

@@ -581,7 +581,7 @@ void RVVEmitter::createRVVIntrinsics(
                 Name, SuffixStr, OverloadedName, OverloadedSuffixStr, IRName,
                 /*IsMask=*/false, /*HasMaskedOffOperand=*/false, HasVL,
                 UnMaskedPolicyScheme, SupportOverloading, HasBuiltinAlias,
-                ManualCodegen, PolicyTypes.getValue(), IntrinsicTypes,
+                ManualCodegen, PolicyTypes.value(), IntrinsicTypes,
                 RequiredFeatures, NF, P, IsPrototypeDefaultTU));
           }
         if (!HasMasked)
@@ -593,7 +593,7 @@ void RVVEmitter::createRVVIntrinsics(
             Name, SuffixStr, OverloadedName, OverloadedSuffixStr, MaskedIRName,
             /*IsMasked=*/true, HasMaskedOffOperand, HasVL, MaskedPolicyScheme,
             SupportOverloading, HasBuiltinAlias, MaskedManualCodegen,
-            MaskTypes.getValue(), IntrinsicTypes, RequiredFeatures, NF,
+            MaskTypes.value(), IntrinsicTypes, RequiredFeatures, NF,
             Policy::PolicyNone, IsPrototypeDefaultTU));
         if (MaskedPolicyScheme == PolicyScheme::SchemeNone)
           continue;
@@ -608,7 +608,7 @@ void RVVEmitter::createRVVIntrinsics(
               Name, SuffixStr, OverloadedName, OverloadedSuffixStr,
               MaskedIRName, /*IsMasked=*/true, HasMaskedOffOperand, HasVL,
               MaskedPolicyScheme, SupportOverloading, HasBuiltinAlias,
-              MaskedManualCodegen, PolicyTypes.getValue(), IntrinsicTypes,
+              MaskedManualCodegen, PolicyTypes.value(), IntrinsicTypes,
               RequiredFeatures, NF, P, IsPrototypeDefaultTU));
         }
       } // End for Log2LMULList

llvm/lib/Analysis/InstructionSimplify.cpp

@@ -2181,10 +2181,10 @@ static Value *simplifyAndInst(Value *Op0, Value *Op1, const SimplifyQuery &Q,
     }
     if (Optional<bool> Implied = isImpliedCondition(Op1, Op0, Q.DL)) {
       // If Op1 is true implies Op0 is true, then Op1 is a subset of Op0.
-      if (Implied.getValue())
+      if (Implied.value())
         return Op1;
       // If Op1 is true implies Op0 is false, then they are not true together.
-      if (!Implied.getValue())
+      if (!Implied.value())
         return ConstantInt::getFalse(Op1->getType());
     }
   }

mlir/include/mlir/IR/OpImplementation.h

@@ -1504,7 +1504,7 @@ public:
     OptionalParseResult result = parseOptionalAssignmentList(lhs, rhs);
     if (!result.has_value())
       return emitError(getCurrentLocation(), "expected '('");
-    return result.getValue();
+    return result.value();
   }
 
   virtual OptionalParseResult

mlir/lib/Dialect/DLTI/DLTI.cpp

@@ -73,11 +73,11 @@ DataLayoutEntryAttr DataLayoutEntryAttr::parse(AsmParser &parser) {
   std::string identifier;
   SMLoc idLoc = parser.getCurrentLocation();
   OptionalParseResult parsedType = parser.parseOptionalType(type);
-  if (parsedType.has_value() && failed(parsedType.getValue()))
+  if (parsedType.has_value() && failed(parsedType.value()))
     return {};
   if (!parsedType.has_value()) {
     OptionalParseResult parsedString = parser.parseOptionalString(&identifier);
-    if (!parsedString.has_value() || failed(parsedString.getValue())) {
+    if (!parsedString.has_value() || failed(parsedString.value())) {
       parser.emitError(idLoc) << "expected a type or a quoted string";
       return {};
     }

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

@@ -344,7 +344,7 @@ static ParseResult parseSwitchOpCases(
     if (values.empty() && !integerParseResult.has_value())
       return success();
 
-    if (!integerParseResult.has_value() || integerParseResult.getValue())
+    if (!integerParseResult.has_value() || integerParseResult.value())
       return failure();
     values.push_back(APInt(bitWidth, value));
 
@@ -542,7 +542,7 @@ parseGEPIndices(OpAsmParser &parser,
     OptionalParseResult parsedInteger =
         parser.parseOptionalInteger(constantIndex);
     if (parsedInteger.has_value()) {
-      if (failed(parsedInteger.getValue()))
+      if (failed(parsedInteger.value()))
         return failure();
       constantIndices.push_back(constantIndex);
       return success();

mlir/lib/Dialect/LLVMIR/IR/LLVMTypeSyntax.cpp

@@ -442,7 +442,7 @@ static Type dispatchParse(AsmParser &parser, bool allowAny = true) {
   Type type;
   OptionalParseResult result = parser.parseOptionalType(type);
   if (result.has_value()) {
-    if (failed(result.getValue()))
+    if (failed(result.value()))
       return nullptr;
     if (!allowAny) {
       parser.emitError(keyLoc) << "unexpected type, expected keyword";

mlir/lib/Dialect/SCF/IR/SCF.cpp

@@ -2613,7 +2613,7 @@ ParseResult scf::WhileOp::parse(OpAsmParser &parser, OperationState &result) {
 
   OptionalParseResult listResult =
       parser.parseOptionalAssignmentList(regionArgs, operands);
-  if (listResult.has_value() && failed(listResult.getValue()))
+  if (listResult.has_value() && failed(listResult.value()))
     return failure();
 
   FunctionType functionType;

mlir/lib/IR/FunctionImplementation.cpp

@@ -42,7 +42,7 @@ parseFunctionArgumentList(OpAsmParser &parser, bool allowVariadic,
         auto argPresent = parser.parseOptionalArgument(
             argument, /*allowType=*/true, /*allowAttrs=*/true);
         if (argPresent.has_value()) {
-          if (failed(argPresent.getValue()))
+          if (failed(argPresent.value()))
             return failure(); // Present but malformed.
 
           // Reject this if the preceding argument was missing a name.

mlir/lib/Interfaces/ViewLikeInterface.cpp

@@ -121,7 +121,7 @@ static ParseResult parseOperandsOrIntegersImpl(
   while (true) {
     OpAsmParser::UnresolvedOperand operand;
     auto res = parser.parseOptionalOperand(operand);
-    if (res.has_value() && succeeded(res.getValue())) {
+    if (res.has_value() && succeeded(res.value())) {
       values.push_back(operand);
       attrVals.push_back(dynVal);
     } else {

mlir/test/lib/Dialect/Test/TestTypes.cpp

@@ -419,7 +419,7 @@ Type TestDialect::parseTestType(AsmParser &parser,
     Type dynType;
     auto parseResult = parseOptionalDynamicType(typeTag, parser, dynType);
     if (parseResult.has_value()) {
-      if (succeeded(parseResult.getValue()))
+      if (succeeded(parseResult.value()))
         return dynType;
       return Type();
     }

mlir/test/lib/Dialect/Transform/TestTransformDialectExtension.cpp

@@ -55,9 +55,9 @@ public:
     if (!result.has_value())
       return success();
 
-    if (result.getValue().succeeded())
+    if (result.value().succeeded())
       state.addAttribute("message", message);
-    return result.getValue();
+    return result.value();
   }
 
   void print(OpAsmPrinter &printer) {

mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp

@@ -683,7 +683,7 @@ static const char *const dialectDynamicAttrParserDispatch = R"(
     ::mlir::Attribute genAttr;
     auto parseResult = parseOptionalDynamicAttr(attrTag, parser, genAttr);
     if (parseResult.has_value()) {
-      if (::mlir::succeeded(parseResult.getValue()))
+      if (::mlir::succeeded(parseResult.value()))
         return genAttr;
       return Attribute();
     }